public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andreas Karlsson <[email protected]>
To: Joe Conway <[email protected]>
To: Chao Li <[email protected]>
To: Bertrand Drouvot <[email protected]>
Cc: [email protected]
Cc: Jeff Davis <[email protected]>
Subject: Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
Date: Tue, 3 Mar 2026 02:22:21 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <aaEhpwrj1FY/8/[email protected]>
	<[email protected]>
	<[email protected]>

On 2/27/26 3:58 PM, Joe Conway wrote:
> On 2/27/26 01:04, Chao Li wrote:
>> What I'm interested in is the broader policy: when reviewing
>> patches, if we encounter a foo() declaration, should we consistently
>> request a change to foo(void)? If yes, the standard should be
>> documented somewhere.
> 
> Perhaps here?
> 
> https://wiki.postgresql.org/wiki/Committing_checklist

Nah, I think we should just enable the warnings unless we have a good 
reason not to.

Andreas

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox