public inbox for [email protected]  

help / color / mirror / Atom feed

From: Drouvot, Bertrand <[email protected]>
To: [email protected]
Cc: Alvaro Herrera <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: tushar <[email protected]>
Cc: [pgdg] Robert Haas <[email protected]>
Cc: Amit Khandekar <[email protected]>
Cc: Rahila Syed <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Minimal logical decoding on standbys
Date: Mon, 22 Mar 2021 15:57:58 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAFcNs+rS7GHh0=oQ1yJRnShH0YwkUen4ec4Rji0W0qFJKtDZcA@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAFcNs+qEA+uxZm_CkZqq+3mGsVe=qtD20qGzBv7xL1sxTMFwFA@mail.gmail.com>
	<[email protected]>
	<CAFcNs+qWENuzW1Re8A=7FMRMOoiwW3qRKJqXeuTYSgVJE7qxeg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAFcNs+otdTGim2YMS5vZPYX-6__ogH4aqcfBKJP2JOo1GBewGQ@mail.gmail.com>
	<[email protected]>
	<CAFcNs+rS7GHh0=oQ1yJRnShH0YwkUen4ec4Rji0W0qFJKtDZcA@mail.gmail.com>


On 3/22/21 3:10 PM, Fabrízio de Royes Mello wrote:
>
> *CAUTION*: This email originated from outside of the organization. Do 
> not click links or open attachments unless you can confirm the sender 
> and know the content is safe.
>
>
>
> On Thu, Mar 18, 2021 at 5:34 AM Drouvot, Bertrand <[email protected] 
> <mailto:[email protected]>> wrote:
> >
> > Thanks!
> >
> > Just made minor changes to make it compiling again on current master 
> (mainly had to take care of 
> ResolveRecoveryConflictWithSnapshotFullXid() that has been introduced 
> in e5d8a99903).
> >
> > Please find enclosed the new patch version that currently passes 
> "make check" and the 2 associated TAP tests.
> >
>
> Unfortunately it still not applying to the current master:
>
> $ git am ~/Downloads/v10-000*.patch
> Applying: Allow logical decoding on standby.
> Applying: Add info in WAL records in preparation for logical slot 
> conflict handling.
> error: patch failed: src/backend/access/nbtree/nbtpage.c:32
> error: src/backend/access/nbtree/nbtpage.c: patch does not apply
> Patch failed at 0002 Add info in WAL records in preparation for 
> logical slot conflict handling.
> hint: Use 'git am --show-current-patch' to see the failed patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".

oh Indeed, it's moving so fast!

Let me rebase it (It was already my plan to do so as I have observed 
during the week end that the 
v7-0003-Handle-logical-slot-conflicts-on-standby.patch 
<https://www.postgresql.org/message-id/attachment/117031/v7-0003-Handle-logical-slot-conflicts-on-sta...; 
introduced incorrect changes (that should not be there at all in 
ReplicationSlotReserveWal()) that have been kept in v8, v9 and v10.

>
>
> > I'll have a look to the whole thread to check if there is anything 
> else waiting in the pipe regarding this feature, unless some of you 
> know off the top of their head?
> >
>
> Will do the same!!!

Thanks!


> But as far I remember last time I checked it everything discussed is 
> covered in this patch set.

That's also what I have observed so far.

Bertrand

view thread (196+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Minimal logical decoding on standbys
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox