agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: David Geier <geidav.pg@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Lukas Fittl <lukas@fittl.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Cc: Maciek Sakrejda <m.sakrejda@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?
Date: Mon, 23 Jan 2023 18:23:17 +0100
Message-ID: <b1aff6c5-53a8-65af-2d3e-71ff2c96b0da@gmail.com> (raw)
In-Reply-To: <20230121041439.zraxavau2wqf2ys3@awork3.anarazel.de>
References: <d6e84dc8-75d1-4c3b-4b32-c4fcb7852275@gmail.com>
<3eaeaa3a-b78e-ef0d-7319-5d713bbc09a0@gmail.com>
<CAP53PkwtWtY-hkSwV7E6g_n657RnFcK0asSp0foSk5Qz_CCJXQ@mail.gmail.com>
<cc72a411-aa07-834c-85c0-489a5924f8bc@gmail.com>
<CALDaNm080KHmRHo8OPcAEj+vNzXejwHgmddji5hkAdCwNsuqKA@mail.gmail.com>
<b201ac3c-1bff-2414-be8e-fc287f78be1a@gmail.com>
<c0c253a0-4825-f295-1583-50f9bbab7d5f@enterprisedb.com>
<CAFj8pRBTZ+TrWpigGERq_7ANom1prCucO6qg3jxXssaLMAh2BA@mail.gmail.com>
<b929cab3-c07f-6d89-5a5f-35d5e5e9ba8a@gmail.com>
<24aa958f-0463-03d4-ce54-20b277c954c6@gmail.com>
<20230121041439.zraxavau2wqf2ys3@awork3.anarazel.de>
Hi,
On 1/21/23 05:14, Andres Freund wrote:
> The elapsed time is already inherently unstable, so we shouldn't have any test
> output showing the time.
>
> But I doubt showing it in every explain is a good idea - we use instr_time in
> plenty of other places. Why show it in explain, but not in all those other
> places?
Yeah. I thought it would only be an issue if we showed it
unconditionally in EXPLAIN ANALYZE. If we only show it with TIMING ON,
we're likely fine with pretty much all regression tests.
But given the different opinions, I'll leave it out in the new patch set
for the moment being.
--
David Geier
(ServiceNow)
view thread (172+ messages) latest in thread
Message-ID: <b1aff6c5-53a8-65af-2d3e-71ff2c96b0da@gmail.com>
Permalink: ../b1aff6c5-53a8-65af-2d3e-71ff2c96b0da@gmail.com/
Also on: postgresql.org/message-id/b1aff6c5-53a8-65af-2d3e-71ff2c96b0da@gmail.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: geidav.pg@gmail.com, andres@anarazel.de, pavel.stehule@gmail.com, tomas.vondra@enterprisedb.com, vignesh21@gmail.com, lukas@fittl.com, michael@paquier.xyz, ibrar.ahmad@gmail.com, m.sakrejda@gmail.com
Subject: Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?
In-Reply-To: <b1aff6c5-53a8-65af-2d3e-71ff2c96b0da@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox