From: Petr Jelinek <petr.jelinek@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: logical decoding vs. VACUUM FULL / CLUSTER on table with TOAST-ed data
Date: Wed, 28 Nov 2018 03:06:58 +0100
Message-ID: <b1c612e3-4ca2-20eb-ca14-6d604f3128db@2ndquadrant.com> (raw)
In-Reply-To: <20181128011439.7ob4i23yyaq5dn4j@alap3.anarazel.de>
References: <1a17c643-e9af-3dba-486b-fbe31bc1823a@2ndquadrant.com>
<CAD21AoB0EfKjgvo3wsT8qhbUpUR=e-B0iqxcv16A-EQujxp0xg@mail.gmail.com>
<9d8e9a45-11e6-740a-b387-83c1c0829263@2ndquadrant.com>
<7a4f2548-d574-c9e4-620f-cae4f00ffb45@2ndquadrant.com>
<530c9399-14b5-2b50-02e3-d3f438578672@2ndquadrant.com>
<20181128011439.7ob4i23yyaq5dn4j@alap3.anarazel.de>
Hi,
On 28/11/2018 02:14, Andres Freund wrote:
> Hi,
>
> On 2018-11-28 02:04:18 +0100, Tomas Vondra wrote:
>>
>> On 11/24/18 12:20 AM, Tomas Vondra wrote:
>>> ...
>>>
>>> OK, here's an updated patch, tweaking the reorderbuffer part. I plan
>>> to push this sometime mid next week.
>>>
>>
>> Pushed and backpatched to 9.4- (same as e9edc1ba).
>
> Backpatching seems on the more aggressive end of things for an
> optimization. Could you at least announce that beforehand next time?
>
Well, it may be optimization, but from what I've seen the problems
arising from this can easily prevent logical replication from working
altogether as reorder buffer hits OOM on bigger tables. So ISTM that it
does warrant backpatch.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: petr.jelinek@2ndquadrant.com, andres@anarazel.de, tomas.vondra@2ndquadrant.com, sawada.mshk@gmail.com
Subject: Re: logical decoding vs. VACUUM FULL / CLUSTER on table with TOAST-ed data
In-Reply-To: <b1c612e3-4ca2-20eb-ca14-6d604f3128db@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox