From: Heikki Linnakangas <hlinnaka@iki.fi>
To: John Naylor <johncnaylorls@gmail.com>
To: Bohyun Lee <bohyun.lee@databricks.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [Patch]The Case For WAL-Logging pg_upgrade
Date: Thu, 6 Aug 2026 10:43:47 +0300
Message-ID: <b1e5047b-e322-4fb5-94f3-474f9425bcaa@iki.fi> (raw)
In-Reply-To: <CANWCAZb8vi_x=nkpOZXW8Nc8-T2VeNj-zZH37-1bQ4+nbgHwbQ@mail.gmail.com>
References: <CAMPh8MpzW86U_CMKq2ndr=-VicjYqSuAx9TowiLNGDiFinhRnQ@mail.gmail.com>
<CANWCAZZBgGeXLUy_Xk7LqMEfY_XMazbE+JZPK8Yzmmk1LEFiSA@mail.gmail.com>
<CAMPh8Mqa3FpdxR5XsPSVFipEv0cDJi2CU6zLDxmZJbH9cvc7QQ@mail.gmail.com>
<CANWCAZbUZy+T7uM59k=1XoabF_2Oj5m=-_CTnhpUTHRKrGVUOQ@mail.gmail.com>
<CAMPh8MqwY8n89RzgGO0mQth66usk_Xssg+BuR6erroc4CBRc7Q@mail.gmail.com>
<CANWCAZb8vi_x=nkpOZXW8Nc8-T2VeNj-zZH37-1bQ4+nbgHwbQ@mail.gmail.com>
On 06/08/2026 01:17, John Naylor wrote:
> On Wed, Aug 5, 2026 at 9:36 PM Bohyun Lee
> <bohyun.lee@databricks.com> wrote:
>> The GUCs are introduced because we cannot assume the standby's
>> storage layout exactly matches the primary's, neither where the
>> retained pre-upgrade directory sits, nor how its files are
>> physically placed. It also depends on how the cluster intends to
>> use the standby. For instance, if the operator wants to keep the
>> standby as a rollback target, it may be worthwhile to use a
>> different transfer mode via the newly introduced
>> pg_upgrade_standby_transfer_mode GUC, which I believe is useful.
>> Nevertheless, the reconstructed cluster will be logically
>> identical, even if the physical representation diverges.
>
> Given the above design concepts, I still think WAL is fundamentally
> the wrong mechanism for this.
Can you elaborate? Do you think the changes that pg_upgrade makes should
be written somewhere else than WAL, or is this just about the transfer
mode setting, or something else? How would you do it?
- Heikki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: hlinnaka@iki.fi, johncnaylorls@gmail.com, bohyun.lee@databricks.com, pgsql-hackers@lists.postgresql.org
Subject: Re: [Patch]The Case For WAL-Logging pg_upgrade
In-Reply-To: <b1e5047b-e322-4fb5-94f3-474f9425bcaa@iki.fi>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox