pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Devrim Gündüz <devrim@gunduz.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: drop support for Python 2.3
Date: Tue, 21 Feb 2017 12:02:52 -0500
Message-ID: <b2e8f44c-7e90-4372-731a-745a72bd4449@2ndquadrant.com> (raw)
In-Reply-To: <7165.1487690305@sss.pgh.pa.us>
References: <7d5073f6-d9ea-ab09-4805-69a12f23e52f@2ndquadrant.com>
	<9516.1486529343@sss.pgh.pa.us>
	<adb38a71-0aa7-087d-2791-4987f3026244@2ndquadrant.com>
	<1486568115.5462.50.camel@gunduz.org>
	<0e2fd256-0a3a-bae8-4ef2-c536139c64cb@2ndquadrant.com>
	<1487493740.2748.13.camel@gunduz.org>
	<797.1487517822@sss.pgh.pa.us>
	<1453.1487518921@sss.pgh.pa.us>
	<1487527748.2748.37.camel@gunduz.org>
	<24334.1487530091@sss.pgh.pa.us>
	<1487535029.3796.1.camel@gunduz.org>
	<633.1487539228@sss.pgh.pa.us>
	<1487565212.4910.3.camel@gunduz.org>
	<664e0d02-20ed-5ae8-7d60-8f779d759072@2ndquadrant.com>
	<7165.1487690305@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 2/21/17 10:18, Tom Lane wrote:
> Based on some not-fun I had along the way to that, I think it would be
> a good idea to do the Python version check a bit earlier than you have
> here.  The shlib search in PGAC_CHECK_PYTHON_EMBED_SETUP is pretty fragile
> and version-dependent, which means that a person could waste a lot of time
> trying to get past the "could not find shared library for Python" error
> before being told that their Python is too old.  I propose to move the
> minimum-version check into _PGAC_CHECK_PYTHON_DIRS, say right after the
> [Python configuration directory] stanza.  Unless there was some specific
> reason for not wanting it to happen in python.m4?

It's fine to move it.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (19+ messages)

Message-ID: <b2e8f44c-7e90-4372-731a-745a72bd4449@2ndquadrant.com>
Permalink:  ../b2e8f44c-7e90-4372-731a-745a72bd4449@2ndquadrant.com/
Also on:    postgresql.org/message-id/b2e8f44c-7e90-4372-731a-745a72bd4449@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, devrim@gunduz.org
  Subject: Re: drop support for Python 2.3
  In-Reply-To: <b2e8f44c-7e90-4372-731a-745a72bd4449@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox