public inbox for [email protected]  

help / color / mirror / Atom feed

From: Heikki Linnakangas <[email protected]>
To: Maxim Orlov <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Yura Sokolov <[email protected]>
Cc: Andres Freund <[email protected]>
Subject: Re: Latches vs lwlock contention
Date: Mon, 4 Nov 2024 18:08:43 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACG=ezYS6sKbWa=Py23jH8P-SXGbZ+z6T_rYaEwfjGfh_yLgrQ@mail.gmail.com>
References: <CA+hUKGKmO7ze0Z6WXKdrLxmvYa=zVGGXOO30MMktufofVwEm1A@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CACG=ezYS6sKbWa=Py23jH8P-SXGbZ+z6T_rYaEwfjGfh_yLgrQ@mail.gmail.com>

On 10/09/2024 19:53, Maxim Orlov wrote:
> I looked at the patch set and found it quite useful.
> 
> The first 7 patches are just refactoring and may be committed separately 
> if needed.
> There were minor problems: patch #5 don't want to apply clearly and the 
> #8 is complained
> about partitionLock is unused if we build without asserts. So, I add a 
> PG_USED_FOR_ASSERTS_ONLY
> to solve the last issue.
> 
> Again, overall patch looks good and seems useful to me. Here is the 
> rebased v5 version based on Heikki's patch set above.

Committed, thanks for the review!

In case you're wondering, I committed some of the smaller patches 
separately, but also squashed some of them with the main patch,  On 
closer look, the first patch, "Remove LOCK_PRINT() call that could point 
to garbage", wasn't fixing any existing issue. The LOCK_PRINT() was 
fine, because we held the partition lock. But it became necessary with 
the main patch, so I squashed it with that. And the others that I 
squashed were just not that interesting on their own.

The rest of Thomas's SetLatches work remains, so I left the commitfest 
entry in "Needs review" state.

-- 
Heikki Linnakangas
Neon (https://neon.tech)

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Latches vs lwlock contention
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox