public inbox for [email protected]  

help / color / mirror / Atom feed

From: Imseih (AWS), Sami <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: Bertrand Drouvot <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Restart pg_usleep when interrupted
Date: Tue, 13 Aug 2024 13:12:30 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <ZruMe-ppopQX4uP8@nathan>
References: <[email protected]>
	<ZrpnfTVK-iaIW98I@nathan>
	<[email protected]>
	<[email protected]>
	<ZrqG0tIgP2HbGRm1@nathan>
	<[email protected]>
	<Zrt3ReA-nB7MJn2q@nathan>
	<[email protected]>
	<ZruCZOKzS0LGAGTb@nathan>
	<[email protected]>
	<ZruMe-ppopQX4uP8@nathan>

> None of this seems intractable to me.  1 Hz seems like an entirely
> reasonable place to start, and it is very easy to change (or to even make
> configurable).  pg_stat_progress_vacuum might show slightly old values in
> this column, but that should be easy enough to explain in the docs if we
> are really concerned about it.  If other callers want to do something
> similar, maybe we should add a more generic implementation in
> backend_progress.c.
>
I don't know if I agree. Making vacuum sleep more robust to handle
interrupts seems like a cleaner general solution than to add
even more code to handle this case or have to explain the behavior of
cost delay instrumentation in docs.


Regards,


Sami

view thread (18+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Restart pg_usleep when interrupted
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox