pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: David Steele <david@pgmasters.net>
To: Masahiko Sawada <sawada.mshk@gmail.com>
To: Adam Brightwell <adam.brightwell@crunchydata.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: Exclude unlogged tables from base backups
Date: Mon, 29 Jan 2018 20:44:16 -0500
Message-ID: <b62e2983-1314-0027-d12e-c417a3e53002@pgmasters.net> (raw)
In-Reply-To: <CAD21AoD9auPq_TWMt-pP4CFOx5Ts-E4avE891Tm6B9KhPDPsfQ@mail.gmail.com>
References: <04791bab-cb04-ba43-e9c0-664a4c1ffb2c@pgmasters.net>
	<20171212225234.jqdwd4sp663l4znp@alap3.anarazel.de>
	<5e428ad7-f37f-6479-aabf-2c8b9318fb79@pgmasters.net>
	<20171212230740.evr7rvkzz5bztdg6@alap3.anarazel.de>
	<20171213014804.GH4628@tamriel.snowman.net>
	<CA+TgmoZho7rVjvSOX9r-qNAHL9oE6OH4VT=C0DUc1ye9JxF-zg@mail.gmail.com>
	<CAD21AoDL_71pWPbTvja+MMVK4F6jMaYU=2asWY9JCRxX6qWetQ@mail.gmail.com>
	<f2c8f9dc-6515-0396-5f82-34dc4e93298e@pgmasters.net>
	<CAD21AoD-qfQrbqQK7_dorpf1ev_yaju6msiE1o9G4CYfGMB08Q@mail.gmail.com>
	<d4fc8171-ea01-161c-279d-4df48d270326@pgmasters.net>
	<CAD21AoAT8WgHYt0xXo7erdt=hcvbJrYtZCd96djKS_vZ8UD2Pw@mail.gmail.com>
	<0d94b6fd-71fc-f7f7-790a-2a4cfbea514b@pgmasters.net>
	<2b2e1879-aa33-afb5-f62d-ea912d5d9887@pgmasters.net>
	<CAE_9P=hGeCo9P4vpnfifnYWkBFKPbwvg-zbkxN3jgNpyFGaimg@mail.gmail.com>
	<CAD21AoD9auPq_TWMt-pP4CFOx5Ts-E4avE891Tm6B9KhPDPsfQ@mail.gmail.com>

On 1/29/18 8:10 PM, Masahiko Sawada wrote:
> On Tue, Jan 30, 2018 at 5:45 AM, Adam Brightwell
> <adam.brightwell@crunchydata.com> wrote:
>> On Mon, Jan 29, 2018 at 1:17 PM, David Steele <david@pgmasters.net> wrote:
>>>
>>> Whoops, my bad.  Temp relations are stored in the db directories with a
>>> "t" prefix.  Looks like we can take care of those easily enough but I
>>> think it should be a separate patch.
>>>
>>> I'll plan to submit that for CF 2018-03.
> 
> +1
> 
>>
>> I agree, I believe this should be a separate patch.
>>
>> As for the latest patch above, I have reviewed, applied and tested it.
>>
>> It looks good to me. As well, it applies cleanly against master at
>> (97d4445a03). All tests passed when running 'check-world'.
>>
>> If it is agreed that the temp file exclusion should be submitted as a
>> separate patch, then I will mark 'ready for committer'.
> 
> Agreed, please mark this patch as "Ready for Committer".

I marked it just in case some enterprising committer from another time
zone swoops in and picks it up.  Fingers crossed!

-- 
-David
david@pgmasters.net




view thread (39+ messages)  latest in thread

Message-ID: <b62e2983-1314-0027-d12e-c417a3e53002@pgmasters.net>
Permalink:  ../b62e2983-1314-0027-d12e-c417a3e53002@pgmasters.net/
Also on:    postgresql.org/message-id/b62e2983-1314-0027-d12e-c417a3e53002@pgmasters.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: david@pgmasters.net, sawada.mshk@gmail.com, adam.brightwell@crunchydata.com, robertmhaas@gmail.com, sfrost@snowman.net
  Subject: Re: PATCH: Exclude unlogged tables from base backups
  In-Reply-To: <b62e2983-1314-0027-d12e-c417a3e53002@pgmasters.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox