public inbox for [email protected]
help / color / mirror / Atom feedFrom: Erik Rijkers <[email protected]>
To: Tatsuo Ishii <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Re: Row pattern recognition
Date: Fri, 22 Sep 2023 10:26:49 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAAWbhmjq3NY1+Am-QHJ4AFh7mi=2eiiGqj518f3-j-C3EfffPg@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
Op 9/22/23 om 10:23 schreef Erik Rijkers:
> Op 9/22/23 om 07:16 schreef Tatsuo Ishii:
>>> Attached is the fix against v6 patch. I will include this in upcoming
>>> v7 patch.
>>
>> Attached is the v7 patch. It includes the fix mentioned above. Also
> (Champion's address bounced; removed)
>
Sorry, I forgot to re-attach the regression.diffs with resend...
Erik
> Hi,
>
> In my hands, make check fails on the rpr test; see attached .diff file.
> In these two statements:
> -- using NEXT
> -- using AFTER MATCH SKIP TO NEXT ROW
> result of first_value(price) and next_value(price) are empty.
>
> Erik Rijkers
>
>
>> this time the pattern matching engine is enhanced: previously it
>> recursed to row direction, which means if the number of rows in a
>> frame is large, it could exceed the limit of stack depth. The new
>> version recurses over matched pattern variables in a row, which is at
>> most 26 which should be small enough.
>>
>> Best reagards,
>> --
>> Tatsuo Ishii
>> SRA OSS LLC
>> English: http://www.sraoss.co.jp/index_en/
>> Japanese:http://www.sraoss.co.jp
>
>
diff -U3 /home/aardvark/pg_stuff/pg_sandbox/pgsql.rpr/src/test/regress/expected/rpr.out /home/aardvark/pg_stuff/pg_sandbox/pgsql.rpr/src/test/regress/results/rpr.out
--- /home/aardvark/pg_stuff/pg_sandbox/pgsql.rpr/src/test/regress/expected/rpr.out 2023-09-22 09:04:17.770392635 +0200
+++ /home/aardvark/pg_stuff/pg_sandbox/pgsql.rpr/src/test/regress/results/rpr.out 2023-09-22 09:38:23.826458109 +0200
@@ -253,23 +253,23 @@
);
company | tdate | price | first_value | last_value
----------+------------+-------+-------------+------------
- company1 | 07-01-2023 | 100 | 100 | 200
+ company1 | 07-01-2023 | 100 | |
company1 | 07-02-2023 | 200 | |
company1 | 07-03-2023 | 150 | |
- company1 | 07-04-2023 | 140 | 140 | 150
+ company1 | 07-04-2023 | 140 | |
company1 | 07-05-2023 | 150 | |
company1 | 07-06-2023 | 90 | |
- company1 | 07-07-2023 | 110 | 110 | 130
+ company1 | 07-07-2023 | 110 | |
company1 | 07-08-2023 | 130 | |
company1 | 07-09-2023 | 120 | |
company1 | 07-10-2023 | 130 | |
- company2 | 07-01-2023 | 50 | 50 | 2000
+ company2 | 07-01-2023 | 50 | |
company2 | 07-02-2023 | 2000 | |
company2 | 07-03-2023 | 1500 | |
- company2 | 07-04-2023 | 1400 | 1400 | 1500
+ company2 | 07-04-2023 | 1400 | |
company2 | 07-05-2023 | 1500 | |
company2 | 07-06-2023 | 60 | |
- company2 | 07-07-2023 | 1100 | 1100 | 1300
+ company2 | 07-07-2023 | 1100 | |
company2 | 07-08-2023 | 1300 | |
company2 | 07-09-2023 | 1200 | |
company2 | 07-10-2023 | 1300 | |
@@ -290,23 +290,23 @@
);
company | tdate | price | first_value | last_value
----------+------------+-------+-------------+------------
- company1 | 07-01-2023 | 100 | 100 | 200
+ company1 | 07-01-2023 | 100 | |
company1 | 07-02-2023 | 200 | |
company1 | 07-03-2023 | 150 | |
- company1 | 07-04-2023 | 140 | 140 | 150
+ company1 | 07-04-2023 | 140 | |
company1 | 07-05-2023 | 150 | |
company1 | 07-06-2023 | 90 | |
- company1 | 07-07-2023 | 110 | 110 | 130
+ company1 | 07-07-2023 | 110 | |
company1 | 07-08-2023 | 130 | |
company1 | 07-09-2023 | 120 | |
company1 | 07-10-2023 | 130 | |
- company2 | 07-01-2023 | 50 | 50 | 2000
+ company2 | 07-01-2023 | 50 | |
company2 | 07-02-2023 | 2000 | |
company2 | 07-03-2023 | 1500 | |
- company2 | 07-04-2023 | 1400 | 1400 | 1500
+ company2 | 07-04-2023 | 1400 | |
company2 | 07-05-2023 | 1500 | |
company2 | 07-06-2023 | 60 | |
- company2 | 07-07-2023 | 1100 | 1100 | 1300
+ company2 | 07-07-2023 | 1100 | |
company2 | 07-08-2023 | 1300 | |
company2 | 07-09-2023 | 1200 | |
company2 | 07-10-2023 | 1300 | |
Attachments:
[text/plain] regression.diffs (3.7K, ../[email protected]/2-regression.diffs)
download | inline:
diff -U3 /home/aardvark/pg_stuff/pg_sandbox/pgsql.rpr/src/test/regress/expected/rpr.out /home/aardvark/pg_stuff/pg_sandbox/pgsql.rpr/src/test/regress/results/rpr.out
--- /home/aardvark/pg_stuff/pg_sandbox/pgsql.rpr/src/test/regress/expected/rpr.out 2023-09-22 09:04:17.770392635 +0200
+++ /home/aardvark/pg_stuff/pg_sandbox/pgsql.rpr/src/test/regress/results/rpr.out 2023-09-22 09:38:23.826458109 +0200
@@ -253,23 +253,23 @@
);
company | tdate | price | first_value | last_value
----------+------------+-------+-------------+------------
- company1 | 07-01-2023 | 100 | 100 | 200
+ company1 | 07-01-2023 | 100 | |
company1 | 07-02-2023 | 200 | |
company1 | 07-03-2023 | 150 | |
- company1 | 07-04-2023 | 140 | 140 | 150
+ company1 | 07-04-2023 | 140 | |
company1 | 07-05-2023 | 150 | |
company1 | 07-06-2023 | 90 | |
- company1 | 07-07-2023 | 110 | 110 | 130
+ company1 | 07-07-2023 | 110 | |
company1 | 07-08-2023 | 130 | |
company1 | 07-09-2023 | 120 | |
company1 | 07-10-2023 | 130 | |
- company2 | 07-01-2023 | 50 | 50 | 2000
+ company2 | 07-01-2023 | 50 | |
company2 | 07-02-2023 | 2000 | |
company2 | 07-03-2023 | 1500 | |
- company2 | 07-04-2023 | 1400 | 1400 | 1500
+ company2 | 07-04-2023 | 1400 | |
company2 | 07-05-2023 | 1500 | |
company2 | 07-06-2023 | 60 | |
- company2 | 07-07-2023 | 1100 | 1100 | 1300
+ company2 | 07-07-2023 | 1100 | |
company2 | 07-08-2023 | 1300 | |
company2 | 07-09-2023 | 1200 | |
company2 | 07-10-2023 | 1300 | |
@@ -290,23 +290,23 @@
);
company | tdate | price | first_value | last_value
----------+------------+-------+-------------+------------
- company1 | 07-01-2023 | 100 | 100 | 200
+ company1 | 07-01-2023 | 100 | |
company1 | 07-02-2023 | 200 | |
company1 | 07-03-2023 | 150 | |
- company1 | 07-04-2023 | 140 | 140 | 150
+ company1 | 07-04-2023 | 140 | |
company1 | 07-05-2023 | 150 | |
company1 | 07-06-2023 | 90 | |
- company1 | 07-07-2023 | 110 | 110 | 130
+ company1 | 07-07-2023 | 110 | |
company1 | 07-08-2023 | 130 | |
company1 | 07-09-2023 | 120 | |
company1 | 07-10-2023 | 130 | |
- company2 | 07-01-2023 | 50 | 50 | 2000
+ company2 | 07-01-2023 | 50 | |
company2 | 07-02-2023 | 2000 | |
company2 | 07-03-2023 | 1500 | |
- company2 | 07-04-2023 | 1400 | 1400 | 1500
+ company2 | 07-04-2023 | 1400 | |
company2 | 07-05-2023 | 1500 | |
company2 | 07-06-2023 | 60 | |
- company2 | 07-07-2023 | 1100 | 1100 | 1300
+ company2 | 07-07-2023 | 1100 | |
company2 | 07-08-2023 | 1300 | |
company2 | 07-09-2023 | 1200 | |
company2 | 07-10-2023 | 1300 | |
view thread (14+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Row pattern recognition
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox