From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Arthur Zakirov <zaartur@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Allow to_date() and to_timestamp() to accept localized names
Date: Fri, 24 Jan 2020 16:24:15 +0100
Message-ID: <b7f37b12-3c59-e5d7-0e59-535a117d259b@2ndquadrant.com> (raw)
In-Reply-To: <20200124114441.GA5753@alvherre.pgsql>
References: <20200124114441.GA5753@alvherre.pgsql>
On 2020-01-24 12:44, Alvaro Herrera wrote:
> On 2020-Jan-24, Juan José Santamaría Flecha wrote:
>
>> There is an open patch that will make the normalization functionality user
>> visible [1]. So, if a user can call to_date(normalize('01 ŞUB 2010'), 'DD
>> TMMON YYYY') I would vote to drop the normalization logic inside this patch
>> altogether.
>
> I was reading the SQL standard on this point, and it says this (4.2.8
> Universal character sets):
>
> An SQL-implementation may assume that all UCS strings are normalized
> in one of [Unicode normalization forms].
>
> which seems to agree with what you're saying.
When you interact with glibc locale functions, you essentially have to
assume that everything is in NFC. When using ICU locale functions
(which we don't here, but just for the sake of argument), then I would
expect that ICU does appropriate normalization itself when I call
icu_what_month_is_this(string) returns int. So I think it is
appropriate to not deal with normalization in this patch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, alvherre@2ndquadrant.com, juanjo.santamaria@gmail.com, tgl@sss.pgh.pa.us, zaartur@gmail.com, tomas.vondra@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Allow to_date() and to_timestamp() to accept localized names
In-Reply-To: <b7f37b12-3c59-e5d7-0e59-535a117d259b@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox