From: bt21tanigaway <bt21tanigaway@oss.nttdata.com>
To: vignesh21@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Printing backtrace of postgres processes
Date: Tue, 12 Oct 2021 14:17:03 +0900
Message-ID: <b93c93fe90346588b06f264a1b4275cf@oss.nttdata.com> (raw)
Hi,
> The previous patch was failing because of the recent test changes made
> by commit 201a76183e2 which unified new and get_new_node, attached
> patch has the changes to handle the changes accordingly.
> Thanks for your update!
> I have two comments.
1.Do we need “set_backtrace(NULL, 0);” on “HandleMainLoopInterrupts()”?
I could observe that it works correctly without this. It is written on
“HandleAutoVacLauncherInterrupts” as well, but I think it is necessary
to prevent delays as well as [1].
2.The patch seems to forget to handle
“ereport(LOG,(errmsg("logging backtrace of PID %d", MyProcPid)));” on
“HandleAutoVacLauncherInterrupts” and “HandleMainLoopInterrupts()”.
I think it should be the same as the process on “ProcessInterrupts()”.
3.How about creating a new function.
Since the same process is on three functions( “ProcessInterrupts()”,
“HandleAutoVacLauncherInterrupts”, “HandleMainLoopInterrupts()” ), I
think it’s good to create a new function.
[1] https://commitfest.postgresql.org/35/3342/
Regards,
Koyu Tanigawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bt21tanigaway@oss.nttdata.com, vignesh21@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Printing backtrace of postgres processes
In-Reply-To: <b93c93fe90346588b06f264a1b4275cf@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox