pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Drouvot, Bertrand <bdrouvot@amazon.com>
Subject: Re: Generating code for query jumbling through gen_node_support.pl
Date: Thu, 26 Jan 2023 09:39:05 +0100
Message-ID: <bafce03e-9536-26e4-36af-387ccc2b01ab@enterprisedb.com> (raw)
In-Reply-To: <Y9By8XDuaLHLNpY0@paquier.xyz>
References: <Y8YakMwx2a6Y63oR@paquier.xyz>
	<e4801c28-cb5b-3b81-bda1-03af8df1fef9@enterprisedb.com>
	<Y8ZTvD6nEqNttAHJ@paquier.xyz>
	<Y8eZ9/3STyhF57RV@paquier.xyz>
	<50b571dc-e0c0-22be-9803-4a3480d2e792@enterprisedb.com>
	<Y8oaA5Vxnr4rzEDJ@paquier.xyz>
	<e4d61d52-4992-d190-b5ad-48c6c752942c@enterprisedb.com>
	<Y8tdmPlzFyNcrPR3@paquier.xyz>
	<bf604c8d-b6e9-284b-327a-cac8417a74e8@enterprisedb.com>
	<Y8+BdCOjxykre5es@paquier.xyz>
	<Y9By8XDuaLHLNpY0@paquier.xyz>

On 25.01.23 01:08, Michael Paquier wrote:
> On Tue, Jan 24, 2023 at 03:57:56PM +0900, Michael Paquier wrote:
>> Makes sense.  That would be my intention if 0004 is the most
>> acceptable and splitting things makes things a bit easier to review.
> 
> There was a silly mistake in 0004 where the jumbling code relied on
> compute_query_id rather than utility_query_id, so fixed and rebased as
> of v7 attached.

Overall, this looks good to me.

There are a couple of repetitive comments, like "typmod and collation 
information are irrelevant for the query jumbling".  This applies to all 
nodes, so we don't need to repeat it for a number of nodes (and then not 
mention it for other nodes).  Maybe there should be a central place 
somewhere that describes "these kinds of fields should normally be ignored".






view thread (44+ messages)  latest in thread

Message-ID: <bafce03e-9536-26e4-36af-387ccc2b01ab@enterprisedb.com>
Permalink:  ../bafce03e-9536-26e4-36af-387ccc2b01ab@enterprisedb.com/
Also on:    postgresql.org/message-id/bafce03e-9536-26e4-36af-387ccc2b01ab@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org, bdrouvot@amazon.com
  Subject: Re: Generating code for query jumbling through gen_node_support.pl
  In-Reply-To: <bafce03e-9536-26e4-36af-387ccc2b01ab@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox