pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Dave Page <dpage@pgadmin.org>
Cc: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pl/perl extension fails on Windows
Date: Thu, 13 Jul 2017 12:14:19 -0400
Message-ID: <bb3d3eb6-e310-471c-1d8c-d239ecaf52ad@2ndQuadrant.com> (raw)
In-Reply-To: <16093.1499956602@sss.pgh.pa.us>
References: <CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com>
	<4569.1499873707@sss.pgh.pa.us>
	<CA+OCxox=h5xftcnyk1AfA_QKSQSruD=Er0qweZakiCEg3U4rcg@mail.gmail.com>
	<6063dd4c-cd1e-d9d8-fa0d-3bddb1403c66@2ndQuadrant.com>
	<CAE9k0PkWhEeNS4b5bnoQLeZsnqe4zqkr=4GhN2Ybt1nSsBFk2g@mail.gmail.com>
	<184f1fb9-dfa2-ef2d-024b-7933486e018a@2ndQuadrant.com>
	<16093.1499956602@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>



On 07/13/2017 10:36 AM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 07/13/2017 08:08 AM, Ashutosh Sharma wrote:
>>> -    dVAR; dXSBOOTARGSAPIVERCHK;
>>> +    dVAR; dXSBOOTARGSNOVERCHK;
>> Good job hunting this down!
>> One suggestion I saw in a little googling was that we add this to the XS
>> file after the inclusion of XSUB.h:
>>     #undef dXSBOOTARGSAPIVERCHK
>>     #define dXSBOOTARGSAPIVERCHK dXSBOOTARGSNOVERCHK
> I don't see anything even vaguely like that in the Util.c file generated
> by Perl 5.10.1, which is what I've got on my RHEL machine.




This is all fairly modern, so it's hardly surprising that it doesn't
happen with the ancient perl 5.10.

here's a snippet from the generated Util.c on crake (Fedora 25, perl 5.24):

    XS_EXTERNAL(boot_PostgreSQL__InServer__Util); /* prototype to pass
    -Wmissing-prototypes */
    XS_EXTERNAL(boot_PostgreSQL__InServer__Util)
    {
    #if PERL_VERSION_LE(5, 21, 5)
        dVAR; dXSARGS;
    #else
        dVAR; dXSBOOTARGSAPIVERCHK;
    #endif



>
> What I do notice is this in Util.xs:
>
> VERSIONCHECK: DISABLE
>
> which leads immediately to two questions:
>
> 1. Why is your version of xsubpp apparently ignoring this directive
> and generating a version check anyway?
>
> 2. Why do we have this directive in the first place?  It does not seem
> to me like a terribly great idea to ignore low-level version mismatches.
>
> In the same vein, I'm suspicious of proposals to "fix" this problem
> by removing the version check, which seems to be where Ashutosh
> is headed.  In the long run that seems certain to cause huge headaches.



That is a different version check. It's the equivalent of xsubpp's
--noversioncheck flag. The versions it would check are the object file
and the corresponding pm file.

In fact the usage I suggested seems to be blessed in XSUB.h in this comment:

    /* dXSBOOTARGSNOVERCHK has no API in xsubpp to choose it so do
    #undef dXSBOOTARGSXSAPIVERCHK
    #define dXSBOOTARGSXSAPIVERCHK dXSBOOTARGSNOVERCHK */





It would be nice to get to the bottom of why we're getting a version
mismatch on Windows, since we're clearly not getting one on Linux. But
since we've got on happily all these years without the API version check
we might well survive a few more going on as we are.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (94+ messages)  latest in thread

Message-ID: <bb3d3eb6-e310-471c-1d8c-d239ecaf52ad@2ndQuadrant.com>
Permalink:  ../bb3d3eb6-e310-471c-1d8c-d239ecaf52ad@2ndQuadrant.com/
Also on:    postgresql.org/message-id/bb3d3eb6-e310-471c-1d8c-d239ecaf52ad@2ndQuadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: andrew.dunstan@2ndquadrant.com, tgl@sss.pgh.pa.us, ashu.coek88@gmail.com, dpage@pgadmin.org, sandeep.thakkar@enterprisedb.com
  Subject: Re: pl/perl extension fails on Windows
  In-Reply-To: <bb3d3eb6-e310-471c-1d8c-d239ecaf52ad@2ndQuadrant.com>
  References: <CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com> <4569.1499873707@sss.pgh.pa.us> <CA+OCxox=h5xftcnyk1AfA_QKSQSruD=Er0qweZakiCEg3U4rcg@mail.gmail.com> <6063dd4c-cd1e-d9d8-fa0d-3bddb1403c66@2ndQuadrant.com> <CAE9k0PkWhEeNS4b5bnoQLeZsnqe4zqkr=4GhN2Ybt1nSsBFk2g@mail.gmail.com> <184f1fb9-dfa2-ef2d-024b-7933486e018a@2ndQuadrant.com> <16093.1499956602@sss.pgh.pa.us> <bb3d3eb6-e310-471c-1d8c-d239ecaf52ad@2ndQuadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox