public inbox for [email protected]
help / color / mirror / Atom feedFrom: Pavel Luzanov <[email protected]>
To: Amit Kapila <[email protected]>
To: Peter Smith <[email protected]>
To: Daniel Gustafsson <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: DOCS: pg_createsubscriber wrong link?
Date: Mon, 16 Dec 2024 18:42:07 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA4eK1KkWW01X-CA6S3y6dRA0DeAg1hYP+uMdnRMEuD84wNW3g@mail.gmail.com>
References: <CAHut+PtnA4DB_pcv4TDr4NjUSM1=P2N_cuZx5DX09k7LVmaqUA@mail.gmail.com>
<CAA4eK1KkWW01X-CA6S3y6dRA0DeAg1hYP+uMdnRMEuD84wNW3g@mail.gmail.com>
On 16.12.2024 13:56, Amit Kapila wrote:
> On Fri, Dec 13, 2024 at 10:58 AM Peter Smith<[email protected]> wrote:
>> While reviewing the pg_createsubscriber [1] docs I found a potentially
>> wrong linkend.
>>
>> This sentence:
>> "For smaller databases, initial data synchronization is recommended."
>>
>> links to [2] ("29.4.5. Initial Data Synchronization").
>>
>> This seems to have been deliberately changed (commit [3])
>>
> Yeah, the change made by commit 84db9a0eb1 is wrong and your latest
> patch in this thread looks good to me. I am adding Daniel and the
> original author to see if they think differently.
It looks like my mistake.
I missed that "Initial Data Synchronization" section is a subsection
of "Row filters". There is no hidden reason other than matching
the link name with the subsection name and my inattention.
v2 of proposed patch looks good to me.
--
Pavel Luzanov
Postgres Professional:https://postgrespro.com
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: DOCS: pg_createsubscriber wrong link?
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox