From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: imai.yoshikazu@fujitsu.com <imai.yoshikazu@fujitsu.com>
Cc: legrand legrand <legrand_legrand@hotmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Planning counters in pg_stat_statements (using pgss_store)
Date: Wed, 1 Apr 2020 18:19:21 +0900
Message-ID: <bd27f039-5285-1fb7-5ed4-57f870c8a5a4@oss.nttdata.com> (raw)
In-Reply-To: <20200331184217.tf3x534uz4vusgmp@nol>
References: <20200329061549.smtokn3ip5pqldia@nol>
<8224bfdf-dcf8-648f-e0d8-1db1d5c215ee@oss.nttdata.com>
<20200330080359.GD79261@nol>
<1c348d6a-02e5-ef14-b9e7-22f7f36fcee1@oss.nttdata.com>
<CAOBaU_YMDofrfRrA4c_kNfFd4ZtwtoTy1XmnBom7rwyVGeFTDw@mail.gmail.com>
<8c6449d4-5fd7-f544-182b-a4bb7da1d18c@oss.nttdata.com>
<20200331060307.e7kypfynz7jous62@nol>
<ac44fd08-5923-c0f7-742d-952a6f5a14a3@oss.nttdata.com>
<20200331073321.bhnx2p63gp5px37f@nol>
<f2b4e098-1b96-e1a8-f601-a0908c9ff8c4@oss.nttdata.com>
<20200331184217.tf3x534uz4vusgmp@nol>
On 2020/04/01 3:42, Julien Rouhaud wrote:
> On Wed, Apr 01, 2020 at 02:43:10AM +0900, Fujii Masao wrote:
>>
>>
>> On 2020/03/31 16:33, Julien Rouhaud wrote:
>>>
>>> v12 attached!
>>
>> Thanks for updating the patch! The patch looks good to me.
>>
>> I applied minor and cosmetic changes into the patch. Attached is
>> the updated version of the patch. Barring any objection, I'd like to
>> commit this version.
>>
>> BTW, the minor and cosmetic changes that I applied are, for example,
>>
>> - Rename pgss_planner_hook to pgss_planner for the sake of consistency.
>> Other function using hook in pgss doesn't use "_hook" in their names, too.
>> - Make pgss_planner use PG_FINALLY() instead of PG_CATCH().
>> - Make PGSS_NUMKIND as the last value in enum pgssStoreKind.
>
>
> +1, and the PGSS_INVALID is also way better.
>
>
>> - Update the sample output in the document.
>> etc
>
>
> Thanks a lot. It all looks good to me!
Thanks for the check!
I tried to pick up the names of authors and reviewers of this patch,
from the past discussions. Then I'm thinking to write the followings
in the commit log. Are there any other developers that should be
credited as author or reviewer?
Author: Julien Rouhaud, Pascal Legrand, Thomas Munro, Fujii Masao
Reviewed-by: Sergei Kornilov, Tomas Vondra, Yoshikazu Imai, Haribabu Kommi, Tom Lane
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, rjuju123@gmail.com, sk@zsrv.org, imai.yoshikazu@fujitsu.com, legrand_legrand@hotmail.com
Subject: Re: Planning counters in pg_stat_statements (using pgss_store)
In-Reply-To: <bd27f039-5285-1fb7-5ed4-57f870c8a5a4@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox