public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrew Dunstan <[email protected]>
To: Kirill Reshke <[email protected]>
Cc: jian he <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: IS JSON predicate support for domain base type as JSON/JSONB/BYTEA/TEXT
Date: Fri, 13 Mar 2026 09:47:52 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALdSSPgSLA2sZ7xY7gc-RFR4wbAamO3ORe32SyRsadZTfX+OVg@mail.gmail.com>
References: <CACJufxEk34DnJFG72CRsPPT4tsJL9arobX0tNPsn7yH28J=zQg@mail.gmail.com>
<[email protected]>
<CACJufxEDN24yBCkFw9sgv2Ocoq=TAtydcJ1ZLR3PEb_NJnTfqA@mail.gmail.com>
<CACJufxF_9FXULmC8fqCNE9H734_RmJ_1jboBpAmL8r-2wO=HOg@mail.gmail.com>
<[email protected]>
<CALdSSPgSLA2sZ7xY7gc-RFR4wbAamO3ORe32SyRsadZTfX+OVg@mail.gmail.com>
On 2026-03-13 Fr 9:16 AM, Kirill Reshke wrote:
> On Fri, 13 Mar 2026 at 17:30, Andrew Dunstan <[email protected]> wrote:
>>
>> On 2026-03-12 Th 11:55 PM, jian he wrote:
>>> Hi.
>>>
>>> The regression test was very verbose; I removed some of it.
>>> Also polished function ExecEvalJsonIsPredicate a little bit.
>>
>>
>> Here's a v4. I changed resultBaseType to exprBaseType - I think it's
>> clearer. I also trimmed the tests a bit more, and dropped the new
>> objects after testing them. The error message now shows the domain name
>> rather than the underlying base type. I think that's more useful.
>>
>
> Hi!
> V4 looks good. The only thing that I cannot explain is removing the
> `exprtype` variable inside ExecEvalJsonIsPredicate. We can just change
> its declaration to
>
> exprtype = pred->exprBaseType if i'm not mistaken?
Yeah, we can do that.
>
> Anyway, LGTM
>
>
Thanks for reviewing.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: IS JSON predicate support for domain base type as JSON/JSONB/BYTEA/TEXT
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox