public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: pgsql-hackers <[email protected]>
Subject: ecpg_config.h symbol missing with meson
Date: Wed, 17 Apr 2024 16:48:22 +0200
Message-ID: <[email protected]> (raw)

I checked the generated ecpg_config.h with make and meson, and the meson 
one is missing

#define HAVE_LONG_LONG_INT 1

This is obviously quite uninteresting, since that is required by C99. 
But it would be more satisfactory if we didn't have discrepancies like 
that.  Note that we also kept ENABLE_THREAD_SAFETY in ecpg_config.h for 
compatibility.

Fixing this on the meson side would be like

diff --git a/src/interfaces/ecpg/include/meson.build 
b/src/interfaces/ecpg/include/meson.build
index 31610fef589..b85486acbea 100644
--- a/src/interfaces/ecpg/include/meson.build
+++ b/src/interfaces/ecpg/include/meson.build
@@ -12,6 +12,7 @@ ecpg_conf_keys = [
  ecpg_conf_data = configuration_data()

  ecpg_conf_data.set('ENABLE_THREAD_SAFETY', 1)
+ecpg_conf_data.set('HAVE_LONG_LONG_INT', 1)

  foreach key : ecpg_conf_keys
    if cdata.has(key)

Alternatively, we could remove the symbol from the make side.

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: ecpg_config.h symbol missing with meson
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox