pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Boris Kolpackov <boris@codesynthesis.com>
To: Alvaro Herrera <alvaro.herrera@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Pipeline mode and PQpipelineSync()
Date: Wed, 23 Jun 2021 13:03:52 +0200
Message-ID: <boris.20210623125826@codesynthesis.com> (raw)
In-Reply-To: <202106230034.w5e33heifbud@alvherre.pgsql>
References: <202106222214.ptjfmstb23mu@alvherre.pgsql>
	<202106230034.w5e33heifbud@alvherre.pgsql>

Alvaro Herrera <alvaro.herrera@2ndquadrant.com> writes:

> On 2021-Jun-22, Alvaro Herrera wrote:
> 
> > > So I think it would be useful to clarify the server behavior and
> > > specify it in the documentation.
> > 
> > I'll see about improving the docs on these points.
> 
> So I started to modify the second paragraph to indicate that the client
> would send data on PQflush/buffer full/PQpipelineSync, only to realize
> that the first paragraph already explains this.  So I'm not sure if any
> changes are needed.
> 
> Maybe your complaint is only based on disagreement about what does libpq
> do regarding queueing commands; and as far as I can tell in quick
> experimentation with libpq, it works as the docs state already.

I think one change that is definitely needed is to make it clear that
the PQpipelineSync() call is not optional.

I would also add a note saying that while the server starts processing
the pipeline immediately, it may buffer the results and the only way
to flush them out is to call PQpipelineSync().





view thread (41+ messages)  latest in thread

Message-ID: <boris.20210623125826@codesynthesis.com>
Permalink:  ../boris.20210623125826@codesynthesis.com/
Also on:    postgresql.org/message-id/boris.20210623125826@codesynthesis.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: boris@codesynthesis.com, alvaro.herrera@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Pipeline mode and PQpipelineSync()
  In-Reply-To: <boris.20210623125826@codesynthesis.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox