pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Boris Kolpackov <boris@codesynthesis.com>
To: Alvaro Herrera <alvaro.herrera@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Pipeline mode and PQpipelineSync()
Date: Thu, 24 Jun 2021 11:00:20 +0200
Message-ID: <boris.20210624103805@codesynthesis.com> (raw)
In-Reply-To: <boris.20210623100839@codesynthesis.com>
References: <boris.20210621100918@codesynthesis.com>
	<202106222214.ptjfmstb23mu@alvherre.pgsql>
	<boris.20210623100839@codesynthesis.com>

Boris Kolpackov <boris@codesynthesis.com> writes:

> What's strange here is that the first PQgetResult() call (marked with ???)
> returns NULL instead of result for INSERT #1 as in the first call sequence.

I've hit another similar case except now an unexpected NULL result is
returned in the middle of PGRES_PIPELINE_ABORTED result sequence. The
call sequence is as follows:

PQsendQueryPrepared() # INSERT #1
PQflush()
PQsendQueryPrepared() # INSERT #2
PQflush()
...
PQsendQueryPrepared() # INSERT #251 -- insert duplicate PK
PQflush()
...
PQsendQueryPrepared() # INSERT #343
PQflush()
PQconsumeInput()      # At this point select() indicates we can read.
PQgetResult()         # NULL -- unexpected but skipped (see prev. email)
PQgetResult()         # INSERT #1
PQgetResult()         # NULL
PQgetResult()         # INSERT #2
PQgetResult()         # NULL
...
PQgetResult()         # INSERT #251 error result, SQLSTATE 23505
PQgetResult()         # NULL
PQgetResult()         # INSERT #252 PGRES_PIPELINE_ABORTED
PQgetResult()         # NULL
PQgetResult()         # INSERT #253 PGRES_PIPELINE_ABORTED
PQgetResult()         # NULL
...
PQgetResult()         # INSERT #343 NULL (???)

Notice that result #343 corresponds to the last PQsendQueryPrepared()
call made before the socket became readable (it's not always 343 but
around there).

For completeness, the statement in question is:

INSERT INTO pgsql_bulk_object (id, idata, sdata) VALUES ($1, $2, $3)

The table:

CREATE TABLE pgsql_bulk_object (
  id BIGINT NOT NULL PRIMARY KEY,
  idata BIGINT NOT NULL,
  sdata TEXT NOT NULL);

And the data inserted is in the form:

1, 1, "1"
2, 2, "2"
...





view thread (41+ messages)  latest in thread

Message-ID: <boris.20210624103805@codesynthesis.com>
Permalink:  ../boris.20210624103805@codesynthesis.com/
Also on:    postgresql.org/message-id/boris.20210624103805@codesynthesis.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: boris@codesynthesis.com, alvaro.herrera@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Pipeline mode and PQpipelineSync()
  In-Reply-To: <boris.20210624103805@codesynthesis.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox