public inbox for [email protected]  

help / color / mirror / Atom feed
From: Tomas Vondra <[email protected]>
To: Palak Chaturvedi <[email protected]>
To: [email protected]
Subject: Re: Changing the state of data checksums in a running cluster
Date: Thu, 2 Jul 2026 10:29:53 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALfch1-earbZTedkbb_3=PgywzBVAc1FXZfz834bb0DKZGDEXw@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAHg+QDfRk4-S7DMmdbXJnQ-xF=sUpMAKuh8b83ObLqYVKx5QLA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAHg+QDfS0Ckw2HT-TWkdvB1pq9rrFzm1Pk_AUwuFL+Er23ZOFA@mail.gmail.com>
	<[email protected]>
	<CAJTYsWUq96LR=DSh0jcbZLwJekT06Z2PGND6GYaS0SANFC9E7A@mail.gmail.com>
	<[email protected]>
	<CAHg+QDeGrpZbNZdLjd_T4b43xKEEXZN0HGhkFm-1bkBdyzK7AQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CALfch1-earbZTedkbb_3=PgywzBVAc1FXZfz834bb0DKZGDEXw@mail.gmail.com>


On 7/2/26 07:06, Palak Chaturvedi wrote:
> Hi Tomas,
> 
> Thanks for these test patches. They are quite useful. I've been going
> through them because we think they'll also help with the TAP tests for
> the online shared_buffers resize work , where I'm ending up reusing
> several of the same helpers (attach_injection_points,
> background_rw_pgbench, and a couple of others).
> Would you be open to lifting these helpers out into a shared Perl module
> (for example under src/test/perl/PostgreSQL/Test/…) so both test suites
> can consume them instead of each copy-pasting? I'm happy to prepare a
> small prep patch on top of your latest version if that sounds reasonable
> to you.
> 

I suppose you mean the functions for managing injection points (waiting,
waking, attachin/detaching, ...)? Yes, it might be useful to have that
in a Perl module, so feel free to create one.


regards

-- 
Tomas Vondra







view thread (60+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Changing the state of data checksums in a running cluster
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox