pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Darafei Komяpa Praliaskouski <me@komzpa.net>
Cc: Pavel Borisov <pashkin.elfe@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Subject: Re: Yet another fast GiST build
Date: Wed, 7 Apr 2021 14:56:42 +0300
Message-ID: <c0846e34-8b3a-e1bf-c88e-021eb241a481@iki.fi> (raw)
In-Reply-To: <6d795a95-bb6b-b993-7c21-64bb7acd3648@iki.fi>
References: <7d9158ca-d7cb-88f0-dbbd-1d5cec32b1ae@iki.fi>
	<4D68C21F-9FB9-41DA-B663-FDFC8D143788@yandex-team.ru>
	<4098005f-e4b5-5904-4b33-335dd106c132@iki.fi>
	<059BD785-A6CE-4E34-B80B-38E9E0309B78@yandex-team.ru>
	<CAH2-WzkBwtk0Np0oZvpiywqjrVwZQtDHSjatJ54ofyezLBxzeQ@mail.gmail.com>
	<8ACF61CC-32ED-4B4B-A2BC-15264E02D24E@yandex-team.ru>
	<3E4F9093-A1B5-4DF8-A292-0B48692E3954@yandex-team.ru>
	<ea7d112f-755e-d194-1777-f10ca6f372b7@iki.fi>
	<9FCEC1DC-86FB-4A57-88EF-DD13663B36AF@yandex-team.ru>
	<c0a679f3-fc3f-4ab0-bb18-b848cd6e9aa6@iki.fi>
	<234863.1610916631@sss.pgh.pa.us>
	<CAH2-WznnqS7HcPhT5F-vFY82iBe4c6eboKB044Tc1N2bWRzuXw@mail.gmail.com>
	<5678c114-c298-ac70-8fba-8bd5c87b048a@iki.fi>
	<CALtqXTeRwyxvdB-fRcMnn4vD5A2rVyLp7+ZNtAuya7Y_u88QHg@mail.gmail.com>
	<CAH2-Wzn4LRvS8GpTrKZKL=s0brg9zm33qTkGMv4Regn6t6DjhQ@mail.gmail.com>
	<CALtqXTcExeND0cjtPiFNiUyANv2V9xfsr4axcnnyGJUYnsReiw@mail.gmail.com>
	<2F3F7265-0D22-44DB-AD71-8554C743D943@yandex-team.ru>
	<6d795a95-bb6b-b993-7c21-64bb7acd3648@iki.fi>

On 07/04/2021 09:00, Heikki Linnakangas wrote:
> On 08/03/2021 19:06, Andrey Borodin wrote:
>> There were numerous GiST-build-related patches in this thread. Yet uncommitted is a patch with sortsupport routines for btree_gist contrib module.
>> Here's its version which needs review.
> 
> Reviewing this now again. One thing caught my eye:
> 
>> +static int
>> +gbt_bit_sort_build_cmp(Datum a, Datum b, SortSupport ssup)
>> +{
>> +	return DatumGetInt32(DirectFunctionCall2(byteacmp,
>> +											 PointerGetDatum(a),
>> +											 PointerGetDatum(b)));
>> +}
> 
> That doesn't quite match the sort order used by the comparison
> functions, gbt_bitlt and such. The comparison functions compare the bits
> first, and use the length as a tie-breaker. Using byteacmp() will
> compare the "bit length" first. However, gbt_bitcmp() also uses
> byteacmp(), so I'm a bit confused. So, huh?

Ok, I think I understand that now. In btree_gist, the *_cmp() function 
operates on non-leaf values, and *_lt(), *_gt() et al operate on leaf 
values. For all other datatypes, the leaf and non-leaf representation is 
the same, but for bit/varbit, the non-leaf representation is different. 
The leaf representation is VarBit, and non-leaf is just the bits without 
the 'bit_len' field. That's why it is indeed correct for gbt_bitcmp() to 
just use byteacmp(), whereas gbt_bitlt() et al compares the 'bit_len' 
field separately. That's subtle, and 100% uncommented.

What that means for this patch is that gbt_bit_sort_build_cmp() should 
*not* call byteacmp(), but bitcmp(). Because it operates on the original 
datatype stored in the table.

- Heikki





view thread (111+ messages)  latest in thread

Message-ID: <c0846e34-8b3a-e1bf-c88e-021eb241a481@iki.fi>
Permalink:  ../c0846e34-8b3a-e1bf-c88e-021eb241a481@iki.fi/
Also on:    postgresql.org/message-id/c0846e34-8b3a-e1bf-c88e-021eb241a481@iki.fi

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: hlinnaka@iki.fi, x4mmm@yandex-team.ru, pg@bowt.ie, tgl@sss.pgh.pa.us, pryzby@telsasoft.com, me@komzpa.net, pashkin.elfe@gmail.com, thomas.munro@gmail.com, michael@paquier.xyz, a.korotkov@postgrespro.ru, ibrar.ahmad@gmail.com
  Subject: Re: Yet another fast GiST build
  In-Reply-To: <c0846e34-8b3a-e1bf-c88e-021eb241a481@iki.fi>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox