From: Bryan Green <dbryan.green@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
To: Jakub Wartak <jakub.wartak@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)
Date: Mon, 27 Oct 2025 12:58:31 -0500
Message-ID: <c23d81e2-97c0-4ef4-a8c4-1ada461fbc1f@gmail.com> (raw)
In-Reply-To: <aPX1fHbUESCMlHq6@paquier.xyz>
References: <a692c0fe-caca-4c08-9c5d-debfd0ef2504@gmail.com>
<CAKZiRmzxyNFGQEM=v1KaN3F3xgn1XYN2Udw+ghyT+sVA_impsg@mail.gmail.com>
<aPX1fHbUESCMlHq6@paquier.xyz>
On 10/20/2025 3:40 AM, Michael Paquier wrote:
> On Mon, Oct 20, 2025 at 10:10:25AM +0200, Jakub Wartak wrote:
>> Cool, thanks for working on this. Win32 is a bit alien to me, but I've
>> got access to win32 so I've played with the patch a little bit. With
>> simple: SET backtrace_functions = 'typenameType'; CREATE TABLE tab (id
>> invalidtype);
>
> Perhaps it would be possible to add some WIN32-specific tests that
> check some log patterns based on the backtraces printed? (I have not
> read the patch in details, just an idea while passing by.)
> --
> Michael
Michael,
Thanks for even glancing at this. I did not add any regression
tests because the output goes to the server log and not the client.
BG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: dbryan.green@gmail.com, michael@paquier.xyz, jakub.wartak@enterprisedb.com
Subject: Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)
In-Reply-To: <c23d81e2-97c0-4ef4-a8c4-1ada461fbc1f@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox