From: Erik Rijkers <er@xs4all.nl>
To: Oliver Ford <ojford@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add RANGE with values and exclusions clauses to the Window Functions
Date: Sat, 27 Jan 2018 08:40:58 +0100
Message-ID: <c30e6457a6de09d26425af997f71996e@xs4all.nl> (raw)
In-Reply-To: <CAGMVOdvJMfOzm0v4psCoAaVGfCbdFwNKzaSEhfTj8rE9UCz-eQ@mail.gmail.com>
References: <CAGMVOdu9sivPAxbNN0X+q19Sfv9edEPv=HibOJhB14TJv_RCQg@mail.gmail.com>
<b2374b9461c349b17b50c77f3a70e1a1@xs4all.nl>
<CAGMVOdsopg5ZAuJh9+ceq-s0pU2qqZsZn-jbL4A1c=h1iWaZVA@mail.gmail.com>
<CAGMVOdvrZCwJg0BngM9GMO+LK=j20vhSfdk1gTTBNNH311Vgsw@mail.gmail.com>
<bc8a1d397fa81d6ae33c297d0224184b@xs4all.nl>
<2c084c1c2bf599ceb2afa87874de8bc1@xs4all.nl>
<CAGMVOdvETRCKpeT06Uoq5RsNUOdH7d1iYy7C1Pze=L5=gBzs-Q@mail.gmail.com>
<cdbe62a6eaddae00fa770c09ed346fc0@xs4all.nl>
<CAGMVOdttRSUU3=tjgdhr902HmUVL1GLQWG0ZTVXi7OY59Xo0Xw@mail.gmail.com>
<13279.1515535159@sss.pgh.pa.us>
<CAGMVOdtYSNJusckQ_9vBkMsZBQzan=Uw-Z-uYG2fD9rZ2TP7pA@mail.gmail.com>
<4139.1515567978@sss.pgh.pa.us>
<CAGMVOdvJMfOzm0v4psCoAaVGfCbdFwNKzaSEhfTj8rE9UCz-eQ@mail.gmail.com>
On 2018-01-27 00:35, Oliver Ford wrote:
> Attached patch implements an extensible version of the RANGE with
> values clause. It doesn't actually add any more type support than was
[...]
> I've tested that the existing regression tests in previous versions
> still pass, and also added new tests for descending mode.
>
> [0001-window-frame-v7.patch]
Hi,
Regression tests only succeed for assert-disabled compiles; they fail
when assert-enabled:
I used (Centos 6.9):
./configure
--prefix=/home/aardvark/pg_stuff/pg_installations/pgsql.frame_range
--bindir=/home/aardvark/pg_stuff/pg_installations/pgsql.frame_range/bin
--libdir=/home/aardvark/pg_stuff/pg_installations/pgsql.frame_range/lib
--with-pgport=6977 --quiet --enable-depend --enable-cassert
--enable-debug --with-openssl --with-perl --with-libxml --with-libxslt
--with-zlib --enable-tap-tests
--with-extra-version=_frame_range_20180127_0757_fb8697b31aae
make check:
[...]
tsearch ... ok
tsdicts ... ok
foreign_data ... ok
window ... FAILED (test process exited with exit
code 2)
xmlmap ... ok
functional_deps ... ok
advisory_lock ... ok
json ... ok
jsonb ... ok
json_encoding ... ok
indirect_toast ... ok
equivclass ... ok
parallel group (19 tests): copy2 plpgsql rowtypes with conversion limit
without_oid rangefuncs plancache prepare sequence largeobject
polymorphism xml temp domain truncate returning alter_table
plancache ... FAILED (test process exited with exit
code 2)
limit ... FAILED (test process exited with exit
code 2)
plpgsql ... FAILED (test process exited with exit
code 2)
copy2 ... FAILED (test process exited with exit
code 2)
temp ... FAILED (test process exited with exit
code 2)
domain ... FAILED (test process exited with exit
code 2)
rangefuncs ... FAILED (test process exited with exit
code 2)
prepare ... FAILED (test process exited with exit
code 2)
without_oid ... FAILED (test process exited with exit
code 2)
conversion ... FAILED (test process exited with exit
code 2)
truncate ... FAILED (test process exited with exit
code 2)
alter_table ... FAILED (test process exited with exit
code 2)
sequence ... FAILED (test process exited with exit
code 2)
polymorphism ... FAILED (test process exited with exit
code 2)
rowtypes ... FAILED (test process exited with exit
code 2)
returning ... FAILED (test process exited with exit
code 2)
largeobject ... FAILED (test process exited with exit
code 2)
with ... FAILED (test process exited with exit
code 2)
xml ... FAILED (test process exited with exit
code 2)
parallel group (6 tests): identity hash_part reloptions partition_join
indexing partition_prune
identity ... FAILED (test process exited with exit
code 2)
partition_join ... FAILED (test process exited with exit
code 2)
partition_prune ... FAILED (test process exited with exit
code 2)
reloptions ... FAILED (test process exited with exit
code 2)
hash_part ... FAILED (test process exited with exit
code 2)
indexing ... FAILED (test process exited with exit
code 2)
test event_trigger ... FAILED (test process exited with exit
code 2)
test stats ... FAILED (test process exited with exit
code 2)
============== shutting down postmaster ==============
=========================
28 of 186 tests failed.
=========================
thanks,
Erik Rijkers
Attachments:
regression.diffs.gz (application/x-gzip, 159.2K) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: er@xs4all.nl, ojford@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: Add RANGE with values and exclusions clauses to the Window Functions
In-Reply-To: <c30e6457a6de09d26425af997f71996e@xs4all.nl>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox