pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Drouvot, Bertrand <bdrouvot@amazon.com>
To: Michael Paquier <michael@paquier.xyz>
To: Jacob Champion <jchampion@timescale.com>
Cc: Joe Conway <mail@joeconway.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: sfrost@snowman.net <sfrost@snowman.net>
Cc: rjuju123@gmail.com <rjuju123@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: andres@anarazel.de <andres@anarazel.de>
Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers
Date: Tue, 23 Aug 2022 10:53:14 +0200
Message-ID: <c4800477-c877-25ab-3ba8-ab53a1510831@amazon.com> (raw)
In-Reply-To: <YwQ6r35/uNC2lm26@paquier.xyz>
References: <CAAWbhmi4OHmk0EVBuQrYcwbotF8uFayDVgkL-H-gqrK0XmeSeg@mail.gmail.com>
	<2a1e2717-8c68-3f9e-1e02-32da71deb327@amazon.com>
	<CAAWbhmiRZMBLCKjJV43skOxiBM71P82O2KMJf-n97t4zUtdqDw@mail.gmail.com>
	<127bd019-04f0-313c-551c-d949cdc4ad50@amazon.com>
	<YvjHFPs2yEDiMLVU@paquier.xyz>
	<520bd3ce-334b-b9c2-2130-858fb04ce56f@amazon.com>
	<CAAWbhmgJ-5YHyOO4ioa-q1bDRexiwMBFru6jJVmV+ShUx_0yeQ@mail.gmail.com>
	<2541c086-e370-d114-69a7-b48b05b25471@amazon.com>
	<YwNpWPCx63D8R8gG@paquier.xyz>
	<CAAWbhmjmwz+QYVTANpmOayfST4x1ey1ZALpgjNwqTeMeH9Ssew@mail.gmail.com>
	<YwQ6r35/uNC2lm26@paquier.xyz>

Hi,

On 8/23/22 4:25 AM, Michael Paquier wrote:
> On Mon, Aug 22, 2022 at 08:10:10AM -0700, Jacob Champion wrote:
>> otherwise I'll sit tight.
> So am I.  I have done an extra round of checks around the
> serialization/deserialization logic where I put some elog()'s to look
> at the output passed down with some workers and a couple of auth
> methods, and after an indentation and some comment polishing I finish
> with the attached.
>
> There was one thing that annoyed me with the patch, though, as of the
> lack of initialization of MyClientConnectionInfo at backend startup,
> as we may finish by not calling set_authn() to fill in some of its
> data, so I have placed an extra memset(0) in InitProcessGlobals()
Fair point.
> (note that Port does a calloc() much earlier than that, but I think
> that we don't really want to do more in such code paths, especially
> for the parallelized client information).
>
> I have written a commit message, while on it.  Does that look fine to
> you?
Thanks!

That sounds all good to me, except a typo for the author in the commit 
message: s/Jocob/Jacob/

Regards,

-- 
Bertrand Drouvot
Amazon Web Services: https://aws.amazon.com






view thread (89+ messages)  latest in thread

Message-ID: <c4800477-c877-25ab-3ba8-ab53a1510831@amazon.com>
Permalink:  ../c4800477-c877-25ab-3ba8-ab53a1510831@amazon.com/
Also on:    postgresql.org/message-id/c4800477-c877-25ab-3ba8-ab53a1510831@amazon.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: bdrouvot@amazon.com, michael@paquier.xyz, jchampion@timescale.com, mail@joeconway.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, sfrost@snowman.net, rjuju123@gmail.com, andres@anarazel.de
  Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers
  In-Reply-To: <c4800477-c877-25ab-3ba8-ab53a1510831@amazon.com>
  References: <CAAWbhmi4OHmk0EVBuQrYcwbotF8uFayDVgkL-H-gqrK0XmeSeg@mail.gmail.com> <2a1e2717-8c68-3f9e-1e02-32da71deb327@amazon.com> <CAAWbhmiRZMBLCKjJV43skOxiBM71P82O2KMJf-n97t4zUtdqDw@mail.gmail.com> <127bd019-04f0-313c-551c-d949cdc4ad50@amazon.com> <YvjHFPs2yEDiMLVU@paquier.xyz> <520bd3ce-334b-b9c2-2130-858fb04ce56f@amazon.com> <CAAWbhmgJ-5YHyOO4ioa-q1bDRexiwMBFru6jJVmV+ShUx_0yeQ@mail.gmail.com> <2541c086-e370-d114-69a7-b48b05b25471@amazon.com> <YwNpWPCx63D8R8gG@paquier.xyz> <CAAWbhmjmwz+QYVTANpmOayfST4x1ey1ZALpgjNwqTeMeH9Ssew@mail.gmail.com> <YwQ6r35/uNC2lm26@paquier.xyz> <c4800477-c877-25ab-3ba8-ab53a1510831@amazon.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox