From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Alexey Bashtanov <bashtanov@imap.cc>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: log bind parameter values on error
Date: Wed, 2 Jan 2019 22:06:23 +0100
Message-ID: <c4891f99-8385-5c31-1aac-e226356ec964@2ndquadrant.com> (raw)
In-Reply-To: <0146a67b-a22a-0519-9082-bc29756b93a2@imap.cc>
References: <0146a67b-a22a-0519-9082-bc29756b93a2@imap.cc>
On 15/12/2018 00:04, Alexey Bashtanov wrote:
> I'd like to propose a patch to log bind parameter values not only when
> logging duration,
> but also on error (timeout in particular) or in whatever situation the
> statement normally gets logged.
> This mostly could be useful when the request originator doesn't log them
> either, so it's hard
> to reproduce the problem.
That's a reasonable problem to solve.
> So I decided to cache textual representations on bind stage,
> which is especially easy if the client uses text protocol.
That sounds like a plausible approach. Have you done any performance
measurements?
In your patch, I would organize the changes to the portal API a bit
differently. Don't change the signature of CreatePortal(). Get rid of
PortalSetCurrentTop() and PortalClearCurrentTop(). Just have a global
variable CurrentPortal and set it directly. And then change
GetCurrentPortalBindParameters() to take a Portal as argument. This can
all happen inside postgres.c without changing the Portal APIs.
In fact, maybe don't use the Portal structure at all and just store the
saved textualized values inside postgres.c in a static variable.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, bashtanov@imap.cc
Subject: Re: log bind parameter values on error
In-Reply-To: <c4891f99-8385-5c31-1aac-e226356ec964@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox