pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Backup command and functions can cause assertion failure and segmentation fault
Date: Wed, 20 Jul 2022 14:00:00 +0900
Message-ID: <c56647fa-4306-7170-17be-d91b627d22f0@oss.nttdata.com> (raw)
In-Reply-To: <YtIkE12Ur3zjG91y@paquier.xyz>
References: <3374718f-9fbf-a950-6d66-d973e027f44c@oss.nttdata.com>
	<CAD21AoBkR611M6K+6i-xNDjmCd-=hFN_svNgRtvuezyjviw1sA@mail.gmail.com>
	<6a759108-a02c-34fd-856c-d7c09d29d2ba@oss.nttdata.com>
	<Yr6XJg2QDT1aHYyJ@paquier.xyz>
	<fa0f1057-923e-ad61-e6f4-ba5fc29135ec@oss.nttdata.com>
	<YsYkPzSpnr5Yt3uA@paquier.xyz>
	<bef8abcd-8cb8-1320-9f2b-bc9677413625@oss.nttdata.com>
	<CA+TgmoYSp060HUuGWbKrZjP+X6kb7dgRiwZZz-hzVEDLkDhZDQ@mail.gmail.com>
	<Ys/NCI4Eo9300GnQ@paquier.xyz>
	<02347f81-304f-3a14-1a33-5f40dfd7da48@oss.nttdata.com>
	<YtIkE12Ur3zjG91y@paquier.xyz>



On 2022/07/16 11:36, Michael Paquier wrote:
> I was thinking about doing that only on HEAD.  One thing interesting
> about this patch is that it can also be used as a point of reference
> for other future things.

Ok, here are review comments:

+my $connstr =
+  $node->connstr('postgres') . " replication=database dbname=postgres";

Since the result of connstr() includes "dbname=postgres", you don't need to add "dbname=postgres" again.

+# The psql command should fail on pg_stop_backup().

Typo: s/pg_stop_backup/pg_stop_backup

I reported two trouble cases; they are the cases where BASE_BACKUP is canceled and terminated, respectively. But you added the test only for one of them. Is this intentional?

>> Since one of them failed to be applied to v14 or before cleanly, I
>> also created the patch for those back branches. So I attached three
>> patches.
> 
> Fine by me.

I pushed these bugfix patches at first. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (18+ messages)  latest in thread

Message-ID: <c56647fa-4306-7170-17be-d91b627d22f0@oss.nttdata.com>
Permalink:  ../c56647fa-4306-7170-17be-d91b627d22f0@oss.nttdata.com/
Also on:    postgresql.org/message-id/c56647fa-4306-7170-17be-d91b627d22f0@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, michael@paquier.xyz, robertmhaas@gmail.com, sawada.mshk@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Backup command and functions can cause assertion failure and segmentation fault
  In-Reply-To: <c56647fa-4306-7170-17be-d91b627d22f0@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox