public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: jian he <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Xuneng Zhou <[email protected]>
Cc: Navneet Kumar <[email protected]>
Cc: [email protected]
Subject: Re: support virtual generated column not null constraint
Date: Fri, 28 Mar 2025 15:06:16 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACJufxEUg7KFv2qXW-wKH1NcSx5GkROXbjML254KtjxvOiwB+g@mail.gmail.com>
References: <CACJufxEoYA5ScUr2=CmA1xcpaS_1ixneDbEkVU77X1ctGxY2mA@mail.gmail.com>
	<[email protected]>
	<CACJufxEUg7KFv2qXW-wKH1NcSx5GkROXbjML254KtjxvOiwB+g@mail.gmail.com>

On 24.03.25 04:26, jian he wrote:
> rebase, and some minor code comments change.

I have committed this.

I did a bit more editing on the naming of various things.  In terms of 
functionality, in ExecConstraints() notnull_virtual_attrs and 
virtual_notnull_check were redundant, so I simplified that.  I also cut 
back a little bit on the assertions.  They were all ok, but I felt in 
some places they bloated the code quite a bit for no real gain.

view thread (17+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: support virtual generated column not null constraint
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox