From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Date: Thu, 16 Dec 2021 12:11:25 +0100
Message-ID: <c7615cf3-621a-7fc4-79ec-6b2554cd5b68@enterprisedb.com> (raw)
In-Reply-To: <YbqYuQkoXm8IytZ0@paquier.xyz>
References: <20211212025017.GN17618@telsasoft.com>
<20211215210916.GC4440@momjian.us>
<711370.1639603043@sss.pgh.pa.us>
<20211215212343.GE4440@momjian.us>
<a89d6602-0fad-c6cc-10cc-20105c4c01ad@dunslane.net>
<20211215221310.GU17618@telsasoft.com>
<YbqYuQkoXm8IytZ0@paquier.xyz>
On 16.12.21 02:39, Michael Paquier wrote:
> On Wed, Dec 15, 2021 at 04:13:10PM -0600, Justin Pryzby wrote:
>> On Wed, Dec 15, 2021 at 05:04:54PM -0500, Andrew Dunstan wrote:
>>> The directory name needs to be predictable somehow, or maybe optionally
>>> set as a parameter. Having just a timestamped directory name would make
>>> life annoying for a poor buildfarm maintainer. Also, please don't change
>>> anything before I have a chance to adjust the buildfarm code to what is
>>> going to be done.
>>
>> Feel free to suggest the desirable behavior.
>> It could write to pg_upgrade.log/* and refuse to run if the dir already exists.
>
> Andrew's point looks rather sensible to me. So, this stuff should
> have a predictable name (pg_upgrade.log, pg_upgrade_log or upgrade_log
> would be fine). But I would also add an option to be able to define a
> custom log path. The latter would be useful for the regression tests
> so as everything gets could get redirected to a path already filtered
> out.
Could we make it write just one log file? Is having multiple log files
better?
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, michael@paquier.xyz, pryzby@telsasoft.com, andrew@dunslane.net, bruce@momjian.us, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
In-Reply-To: <c7615cf3-621a-7fc4-79ec-6b2554cd5b68@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox