public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Eisentraut <[email protected]>
To: Corey Huinker <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: appendBinaryStringInfo stuff
Date: Tue, 14 Feb 2023 13:51:02 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CADkLM=cprBDinpS71gWNKUc48cciRuBQou76Q2gCSfrvboNFxQ@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CADkLM=cprBDinpS71gWNKUc48cciRuBQou76Q2gCSfrvboNFxQ@mail.gmail.com>
On 10.02.23 20:08, Corey Huinker wrote:
>
>
> On Fri, Feb 10, 2023 at 7:16 AM Peter Eisentraut
> <[email protected]
> <mailto:[email protected]>> wrote:
>
> On 19.12.22 07:13, Peter Eisentraut wrote:
> > Also, the argument type of appendBinaryStringInfo() is char *.
> There is
> > some code that uses this function to assemble some kind of packed
> binary
> > layout, which requires a bunch of casts because of this. I think
> > functions taking binary data plus length should take void * instead,
> > like memcpy() for example.
>
> I found a little follow-up for this one: Make the same change to
> pq_sendbytes(), which is a thin wrapper around
> appendBinaryStringInfo().
> This would allow getting rid of further casts at call sites.
>
>
> +1
>
> Has all the benefits that 54a177a948b0a773c25c6737d1cc3cc49222a526 had.
>
> Passes make check-world.
committed, thanks
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: appendBinaryStringInfo stuff
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox