public inbox for [email protected]  
help / color / mirror / Atom feed
From: Peter Eisentraut <[email protected]>
To: jian he <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Marcos Pegoraro <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: Tom Lane <[email protected]>
Subject: Re: add function argument name to substring and substr
Date: Fri, 27 Mar 2026 16:52:55 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACJufxHpSD2uKM92aWiRjQLiMvJb+m4WDKfeVL=L=zBR0jBEAw@mail.gmail.com>
References: <CACJufxHTBkymh06D4mGKNe1YfRNFN+gFBybmygWk=PtMqu00LQ@mail.gmail.com>
	<CACJufxFpzqdfYvsj2iWhtemRyPSB5O7_gb9vRd7cE1ZcVvmZnw@mail.gmail.com>
	<CAKFQuwa-j+oA23EVA7qk+AUdpi24d1LC_O9MH5oSnzOv2McEhg@mail.gmail.com>
	<CACJufxH0jqshH6SC97eQ7T=QcSYpbtKMR2=wmds=K2UT9t0tFw@mail.gmail.com>
	<CAKFQuwbPdo1MORJqnQj=eA6bGrvGu_U+8J+oTWw7QDvuX2oAQw@mail.gmail.com>
	<CACJufxGF6vU7KUMqHL0RehdvwVBENz2Q++ZyGJaCzk2_VVPqWQ@mail.gmail.com>
	<CAKFQuwZU=eY0F6jE4ekuPs5FMqNr2e-mJ=MTuaZTeDG+Xti1=g@mail.gmail.com>
	<CAB-JLwathhELcwARpTJ5cAh-Z6tS6V8PCXti9woGZMJiqzCPfA@mail.gmail.com>
	<CAKFQuwYSRa_Q-qpXMosT4HYx62aGjkiNA2A-d6dZhzTamHs6dw@mail.gmail.com>
	<CACJufxHbWiZLwzKs6k4+w=UjA_wDEEhWgH2fpUexxgvHOP_OWA@mail.gmail.com>
	<CACJufxHDCHsKp_8U8cQvnQpa8mPy1bJ5jjdcmjHGT9weoAT4bg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CACJufxFZA2_kDz=bs_8ES_6NgCa+KeXdtiH7+4KLvX8xCsFCcg@mail.gmail.com>
	<CACJufxHpSD2uKM92aWiRjQLiMvJb+m4WDKfeVL=L=zBR0jBEAw@mail.gmail.com>

On 31.12.25 08:47, jian he wrote:
> rebased, and rechecked it again.
> 
> seems no changes to the citext extension are required, since the citext data
> type does not define specialized substring/substr function.

I don't really see the point of this.  These are standardized functions, 
and people should be using them in the standardized ways.  By adding 
parameter names, we are opening up the use of these in nonstandard and 
unportable ways.  I don't think the arguments of these functions are 
terribly confusing that use of named parameters adds much value.  At 
least I didn't see this argument being made.

Furthermore, if we somehow decided to do this, let's not do it four 
functions at a time but have a general plan about whether, why, and how 
to add parameter names to built-in/standard functions.






view thread (20+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: add function argument name to substring and substr
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox