public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tomas Vondra <[email protected]>
To: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Fix for pageinspect bug in PG 17
Date: Tue, 17 Dec 2024 18:01:39 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <TYAPR01MB5692A621179C18A8FDB3AE60F55B2@TYAPR01MB5692.jpnprd01.prod.outlook.com>
References: <[email protected]>
	<TYAPR01MB56926215D57A11B12F9E7DA3F5592@TYAPR01MB5692.jpnprd01.prod.outlook.com>
	<[email protected]>
	<TYAPR01MB5692A621179C18A8FDB3AE60F55B2@TYAPR01MB5692.jpnprd01.prod.outlook.com>

I've pushed (and backpatched) a fix for this.

I ended up doing the simplest thing -- error out if the number of
columns does not match, suggesting to update to latest extension version.

I considered handling it in a nicer way, but I didn't like the result
very much and I think that's sufficient for superuser-only extension.
And 691e8b2e18 seems like a reasonable precedent (even though the
backbranches did do a different thing).

I also considered introducing pg_stat_statements-style versioning, but
it's too late to do that in backbranches, and I don't think we expect
the function to change very often to justify this.

regards

-- 
Tomas Vondra

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Fix for pageinspect bug in PG 17
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox