From: Arthur Zakirov <a.zakirov@postgrespro.ru>
To: s.cherkashin@postgrespro.ru, Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Psql patch to show access methods info
Date: Tue, 20 Nov 2018 17:32:57 +0300
Message-ID: <c94f871f-12e5-304e-a6b1-08eab7a94187@postgrespro.ru> (raw)
In-Reply-To: <64178681578cd2f1013db32bb7c00ddd@postgrespro.ru>
References: <20181120104153.mgl5qy6uowryhesn@alvherre.pgsql>
<64178681578cd2f1013db32bb7c00ddd@postgrespro.ru>
Hello,
On 20.11.2018 16:08, s.cherkashin@postgrespro.ru wrote:
> Ok, I fixed this.
I looked at the patch. It is in good shape. It compiles and tests are
passed.
I have few a questions related with throwing errors. They might be silly :)
\dAp as well as \dA command throw an error if a server's version below 9.6:
"The server (version %s) does not support access methods"
But other \dA commands don't. It seems that there is enough information
in catalog for servers below 9.6. That is there are pg_am, pg_opfamily,
pg_amop and other catalog tables related with access methods.
\dAp calls pg_indexam_has_property() function, which doesn't exist in
servers 9.5 and below. Is this the reason that it throws an error? If so
then describeOneIndexColumnProperties() also should throw an error,
because it calls pg_index_column_has_property() function, which doesn't
exist in servers 9.5 and below.
What do you think?
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.zakirov@postgrespro.ru, alvherre@2ndquadrant.com, michael@paquier.xyz, n.gluhov@postgrespro.ru
Subject: Re: Psql patch to show access methods info
In-Reply-To: <c94f871f-12e5-304e-a6b1-08eab7a94187@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox