pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jacob Champion <jchampion@timescale.com>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Log details for client certificate failures
Date: Fri, 15 Jul 2022 13:20:59 -0700
Message-ID: <ca6eb74e-aafc-f7cc-50fd-a6b33bca858b@timescale.com> (raw)
In-Reply-To: <20220715191156.jecddreykoakdljm@awork3.anarazel.de>
References: <CAAWbhmggsEacYW+cahN7USucsTgK9P4c5VMLaxWRdXvGQ=+BHA@mail.gmail.com>
	<CAAWbhmiHyYajeN-SGRo_Nix+XbLtMyVkWinAoFVFy1kpbWT-zg@mail.gmail.com>
	<61aa4b6c-9de2-d61b-821a-a34ab1e515e2@enterprisedb.com>
	<CAAWbhmgtVs0VciBwL4KbhQnLfTQKqwJjUUCxzA3SFECPn=ntTA@mail.gmail.com>
	<2ef20161-e99d-a6ea-a36d-577843a2daae@enterprisedb.com>
	<CAAWbhmiQVSAc_rOdW8q9R3GJehxkmaW5-CMbYLgrCjhotSs8Bg@mail.gmail.com>
	<49b48719-d6cf-9e03-fab3-e4505cf9d585@enterprisedb.com>
	<CAAWbhmhbM5zwjjVsYkhTOFrV308iFbsGceWiseSbFPQeq24Fww@mail.gmail.com>
	<059e67f5-3769-24c8-f460-4e5d87af529a@enterprisedb.com>
	<0167a8c5-1754-9121-b994-0719a6493a21@timescale.com>
	<20220715191156.jecddreykoakdljm@awork3.anarazel.de>

On 7/15/22 12:11, Andres Freund wrote:
> This might have been discussed somewhere, but I'm worried about emitting
> unescaped data from pre-auth clients. What guarantees that subject / issuer
> name only contain printable ascii-chars? Printing terminal control chars or
> such would not be great, nor would splitting a string at a multi-boundary.

Hm. The last time I asked about that, Magnus pointed out that we reflect
port->user_name as-is [1], so I kind of stopped worrying about it. Is
this more dangerous than that? (And do we want to fix it now,
regardless?) What guarantees are we supposed to be making for log encoding?

Thanks,
--Jacob

[1]
https://www.postgresql.org/message-id/CABUevExVHryTasKmtJW5RtU-dBesYj4bV7ggpeVMfiPCHCvLNA%40mail.gma...





view thread (54+ messages)  latest in thread

Message-ID: <ca6eb74e-aafc-f7cc-50fd-a6b33bca858b@timescale.com>
Permalink:  ../ca6eb74e-aafc-f7cc-50fd-a6b33bca858b@timescale.com/
Also on:    postgresql.org/message-id/ca6eb74e-aafc-f7cc-50fd-a6b33bca858b@timescale.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: jchampion@timescale.com, andres@anarazel.de, peter.eisentraut@enterprisedb.com
  Subject: Re: [PATCH] Log details for client certificate failures
  In-Reply-To: <ca6eb74e-aafc-f7cc-50fd-a6b33bca858b@timescale.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox