pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: gkokolatos@pm.me
To: michael@paquier.xyz
Cc: andrew@dunslane.net
Cc: exclusion@gmail.com
Cc: pryzby@telsasoft.com
Cc: shiy.fnst@fujitsu.com
Cc: pgsql-hackers@lists.postgresql.org
Cc: rachelmheaton@gmail.com
Subject: Re: Add LZ4 compression in pg_dump
Date: Mon, 8 May 2023 03:34:15 +0200
Message-ID: <cd02d444-b4f5-3cb8-d814-46c8ea035e6c@enterprisedb.com> (raw)
In-Reply-To: <Y15gcrC3SU2y5u63cE3p9APTZ-s6aOoeIu1MX29nVycUpq0l7dss7chpw1P7jdB5Nrs49KwabqdlW1Q50ApVd9GuxLUtFsI-MmQq7ZCY-H8=@pm.me>
References: <7zu6GYFi72jByVk2SEe_nd8r1DHhwA35vSntAE9sAfiMX9Lfk6bwimkwmu7GDgYaEvL27SE4qF1uK4_LHWQM4H-SXOwkMAI-GV8PKGmED_E=@pm.me>
	<XPMIIorJ5munrlLRZGquartiN5tuapdjiBhaPZ6iEmJccRiKWCIHSowSLPhaGj4gLpqvaS1pQn7PGkA_WNwvuUTVdl-lrU_TzHA81LqujJ4=@pm.me>
	<ZBjg4D/X05X+JbcJ@telsasoft.com>
	<3beb0dd7-c927-3eca-689f-716e255d5b27@enterprisedb.com>
	<94ae9bca-5ebb-1e68-bb7b-4f32e89fefbe@gmail.com>
	<MmuCeC4k017VCWzr-f8MEQ9hx8DRak2ZGbb5SVwKvBBHqCt8tLKzVVdMcPMsi3Zj314OJbs1UPEzwc5RwOv3IMp1lAkC7rg-yDOaDBJGww8=@pm.me>
	<71868915-0345-1b7b-f3d6-ec66547c662a@dunslane.net>
	<P-Dl7-QRVPmjv35H2n-Wnj9amDG_MUEb0-jtlzs05n5z03lq0IZNTsI5h4DjTmLekfmKexgFBQhmVXtUO402vAIFx0e002lIzsb8O8Hi1wA=@pm.me>
	<ZFXAp30HxBH2e4+Q@paquier.xyz>
	<Y15gcrC3SU2y5u63cE3p9APTZ-s6aOoeIu1MX29nVycUpq0l7dss7chpw1P7jdB5Nrs49KwabqdlW1Q50ApVd9GuxLUtFsI-MmQq7ZCY-H8=@pm.me>



On 5/7/23 17:01, gkokolatos@pm.me wrote:
> 
> 
> 
> On Sat, May 6, 2023 at 04:51, Michael Paquier <michael@paquier.xyz
> <mailto:On Sat, May 6, 2023 at 04:51, Michael Paquier <<a href=>> wrote:
>> On Fri, May 05, 2023 at 02:13:28PM +0000, gkokolatos@pm.me wrote:
>> > Good point. I thought about it before submitting the patch. I
>> > concluded that given the complexity and operations involved in
>> > LZ4Stream_read_internal() and the rest of t he pg_dump/pg_restore
>> > code, the memset() call will be negligible. However from the
>> > readability point of view, the function is a bit cleaner with the
>> > memset().
>> >
>> > I will not object to any suggestion though, as this is a very
>> > trivial point. Please find attached a v2 of the patch following the
>> > suggested approach.
>>
>> Please note that an open item has been added for this stuff.
> Thank you but I am not certain I know what that means. Can you please
> explain?
> 

It means it was added to the list of items we need to fix before PG16
gets out:

https://wiki.postgresql.org/wiki/PostgreSQL_16_Open_Items


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





view thread (205+ messages)  latest in thread

Message-ID: <cd02d444-b4f5-3cb8-d814-46c8ea035e6c@enterprisedb.com>
Permalink:  ../cd02d444-b4f5-3cb8-d814-46c8ea035e6c@enterprisedb.com/
Also on:    postgresql.org/message-id/cd02d444-b4f5-3cb8-d814-46c8ea035e6c@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@enterprisedb.com, gkokolatos@pm.me, michael@paquier.xyz, andrew@dunslane.net, exclusion@gmail.com, pryzby@telsasoft.com, shiy.fnst@fujitsu.com, pgsql-hackers@lists.postgresql.org, rachelmheaton@gmail.com
  Subject: Re: Add LZ4 compression in pg_dump
  In-Reply-To: <cd02d444-b4f5-3cb8-d814-46c8ea035e6c@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox