public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Eisentraut <[email protected]>
To: jian he <[email protected]>
To: PostgreSQL-development <[email protected]>
Cc: Paul A Jungwirth <[email protected]>
Subject: Re: FOR PORTION OF gram.y target_location seems wrong
Date: Mon, 27 Apr 2026 12:04:54 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACJufxEKdga8bEE4mkMDVYJ78V_7Orj7M8FcsYk_VnsY4Bv4aA@mail.gmail.com>
References: <CACJufxEKdga8bEE4mkMDVYJ78V_7Orj7M8FcsYk_VnsY4Bv4aA@mail.gmail.com>
On 24.04.26 03:10, jian he wrote:
> Hi.
>
> | FOR PORTION OF ColId FROM a_expr TO a_expr
> {
> ForPortionOfClause *n = makeNode(ForPortionOfClause);
> n->range_name = $4;
> n->location = @4;
> n->target_start = $6;
> n->target_end = $8;
> n->target_location = @5;
> $$ = (Node *) n;
> }
>
> n->target_location = @5;
>
> Should be
>
> n->target_location = @6;
I think the existing code is fine. The target consists of the start and
the end value. If we pointed to @6 then one could be confused into
thinking that only the start value is meant.
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: FOR PORTION OF gram.y target_location seems wrong
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox