pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Imai, Yoshikazu <imai.yoshikazu@jp.fujitsu.com>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: speeding up planning with partitions
Date: Mon, 4 Mar 2019 11:20:48 -0500
Message-ID: <ce7bb7c2-8eac-0047-1e04-e771f08ad1fb@redhat.com> (raw)
In-Reply-To: <b5362c29-cca1-de7b-13d0-9e51f9911185@lab.ntt.co.jp>
References: <CAKJS1f9XAePd2+8F4=wtHKdDdckgKcSoXb-ZbU8Wbt86mhLxKA@mail.gmail.com>
	<b8a139b8-2f5d-6079-67b2-99957af3fc36@lab.ntt.co.jp>
	<7453.1550518972@sss.pgh.pa.us>
	<0a70234e-b2e6-debc-2fb5-e8fd927caa00@lab.ntt.co.jp>
	<1002.1550596071@sss.pgh.pa.us>
	<30961.1550609873@sss.pgh.pa.us>
	<250c61bc-479c-92f4-d19d-d768e3bcdcbc@lab.ntt.co.jp>
	<13510.1550677844@sss.pgh.pa.us>
	<a47e6214-bd46-ab4b-2f84-f9f726e04642@lab.ntt.co.jp>
	<35b02675-83c2-a12b-961a-fec249b06f35@lab.ntt.co.jp>
	<20190222165932.GG28750@telsasoft.com>
	<CA+HiwqEUwfg4s=4=is-+7k-WM-2Gs9K3iFB96QNm_eafcBozqQ@mail.gmail.com>
	<0F97FA9ABBDBE54F91744A9B37151A51293422@g01jpexmbkw24>
	<8098beec-fc04-303d-55b9-73c3d94ba1ea@lab.ntt.co.jp>
	<b5362c29-cca1-de7b-13d0-9e51f9911185@lab.ntt.co.jp>

Hi Amit,

Passes check-world.

On 3/4/19 5:38 AM, Amit Langote wrote:
> See patch 0001.
> 

+* members of any appendrels we find here are added built later when

s/built//

> See patch 0002.
>

+		grouping_planner(root, false, 0.0 /* retrieve all tuples */);

Move comment out of function call.

+		if (root->simple_rte_array[childRTindex])
+			elog(ERROR, "rel %d already exists", childRTindex);
+		root->simple_rte_array[childRTindex] = childrte;
+		if (root->append_rel_array[childRTindex])
+			elog(ERROR, "child relation %d already exists", childRTindex);
+		root->append_rel_array[childRTindex] = appinfo;


Could the "if"s be made into Assert's instead ?

+ *		the	newly added bytes with zero

Extra spaces

+	if (rte->rtekind == RTE_RELATION &&	!root->contains_inherit_children)

s/TAB/space

> See patch 0003.
> 

+	 * because they correspond to flattneed UNION ALL subqueries.  Especially,

s/flattneed/flatten

> See patch 0004.
> 

+	 * no need to make any new entries, because anything that'd need those

Use "would" explicit

+ * this case, since it needn't be scanned.

, since it doesn't need to be scanned

> See patch 0005.
>
> See patch 0006.
>

I'll run some tests using a hash partitioned setup.

Best regards,
  Jesper




view thread (265+ messages)  latest in thread

Message-ID: <ce7bb7c2-8eac-0047-1e04-e771f08ad1fb@redhat.com>
Permalink:  ../ce7bb7c2-8eac-0047-1e04-e771f08ad1fb@redhat.com/
Also on:    postgresql.org/message-id/ce7bb7c2-8eac-0047-1e04-e771f08ad1fb@redhat.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: jesper.pedersen@redhat.com, Langote_Amit_f8@lab.ntt.co.jp, imai.yoshikazu@jp.fujitsu.com, amitlangote09@gmail.com, tgl@sss.pgh.pa.us, david.rowley@2ndquadrant.com, alvherre@2ndquadrant.com, pryzby@telsasoft.com
  Subject: Re: speeding up planning with partitions
  In-Reply-To: <ce7bb7c2-8eac-0047-1e04-e771f08ad1fb@redhat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox