public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Brar Piening <[email protected]>
To: Alvaro Herrera <[email protected]>
To: Karl O. Pinc <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Ian Lawrence Barwick <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: doc: add missing "id" attributes to extension packaging page
Date: Thu, 6 Apr 2023 11:06:18 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 04.04.23 21:52, Brar Piening wrote:
>> The XSLT implementation looks sound to me.  It would be a touch better
>> if it had some comments about which parts of the templates were copied
>> from upstream stylesheets and which were changed.  There are examples
>> of such commenting in the existing customization layer.  Also, avoid
>> introducing whitespace differences during said copying.
> 
> I will amend the patch if we agree that this is the way forward.

Ok, it appears everyone agrees that this is the correct approach. 
Please post an updated patch.  There have been so many partial patches 
posted recently, I'm not sure which one is the most current one and who 
is really the author.

view thread (35+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: doc: add missing "id" attributes to extension packaging page
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox