pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrei Lepikhov <lepihov@gmail.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: David Rowley <dgrowleyml@gmail.com>
Subject: Re: Reordering DISTINCT keys to match input path's pathkeys
Date: Fri, 22 Nov 2024 15:39:02 +0700
Message-ID: <cea712ca-d5db-432e-9170-bcb1ed3b95ee@gmail.com> (raw)
In-Reply-To: <CAMbWs4-SHEBahuQCo7-4yK4=CmEP6jd5RwKbGUB2akFB79mCCQ@mail.gmail.com>
References: <CAMbWs48dR26cCcX0f=8bja2JKQPcU64136kHk=xekHT9xschiQ@mail.gmail.com>
	<CAApHDvq39jp0EXbtu0Kwx7um_x54MiFcKx2sNj9kdTc9TEYu7g@mail.gmail.com>
	<CAMbWs4-+gBN4sQ7wyEptrsKO1AxJHOocxWQ72=bX1g1=9cOrSA@mail.gmail.com>
	<CAMbWs48j2xnk3WpO55dJU-4yoSMRb56=qf=zKPfb5driTwH-Yg@mail.gmail.com>
	<CAMbWs49gL-c=xBuQTQcVSMjsAnUhDt1-x6BZHkNskvcVdZ94gw@mail.gmail.com>
	<0fc11a92-f6e4-4d8c-b882-91283ef54bce@gmail.com>
	<CAMbWs4-SHEBahuQCo7-4yK4=CmEP6jd5RwKbGUB2akFB79mCCQ@mail.gmail.com>

On 11/13/24 13:49, Richard Guo wrote:
> On Mon, Oct 28, 2024 at 6:15 PM Andrei Lepikhov <lepihov@gmail.com> wrote:
>> On 6/7/24 16:46, Richard Guo wrote:
> I'm not sure about merging these two 'reordering' GUCs into one.
> While they may look similar, they apply to very different scenarios.
> However, I'm open to other suggestions.
I finally have passed through the code. It generally looks OK. Let me 
only write a few words on tests.
I wonder if it would be possible to print only three rows instead of 10 
to prove the DISTINCT's correctness.
Also, to stabilise tests with parallel workers, I would recommend 
setting max_parallel_workers_per_gather into 1 and enabling 
debug_parallel_query.

-- 
regards, Andrei Lepikhov





view thread (17+ messages)  latest in thread

Message-ID: <cea712ca-d5db-432e-9170-bcb1ed3b95ee@gmail.com>
Permalink:  ../cea712ca-d5db-432e-9170-bcb1ed3b95ee@gmail.com/
Also on:    postgresql.org/message-id/cea712ca-d5db-432e-9170-bcb1ed3b95ee@gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: lepihov@gmail.com, guofenglinux@gmail.com, dgrowleyml@gmail.com
  Subject: Re: Reordering DISTINCT keys to match input path's pathkeys
  In-Reply-To: <cea712ca-d5db-432e-9170-bcb1ed3b95ee@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox