From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: add more NLS to bin
Date: Thu, 3 Nov 2016 12:44:18 -0400
Message-ID: <cfb0f746-ee20-226d-ff7c-a1e1b8d13445@2ndquadrant.com> (raw)
In-Reply-To: <CAB7nPqQTCkVhmf2u5Tu65To_MidUJhD_+WfNe31jueuH74vH_w@mail.gmail.com>
References: <bd794aca-572a-ac22-293c-3ea548881b76@2ndquadrant.com>
<CAB7nPqQTCkVhmf2u5Tu65To_MidUJhD_+WfNe31jueuH74vH_w@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 10/31/16 1:58 AM, Michael Paquier wrote:
> 2) For 0002 and pg_test_fsync, I am seeing a missing entry:
> printf(NA_FORMAT, "n/a*\n");
ok
> 4) 0004 and pg_upgrade... In check.c, three places like that:
> if (!db_used)
> {
> fprintf(script, "Database: %s\n", active_db->db_name);
> db_used = true;
> }
>
> In exec.c:
> #endif
> fprintf(log, "command: %s\n", cmd);
> #ifdef WIN32
These and several of the other places write into log or script files. I
have chosen not to do anything about those for now. That might be a
future change, or we just leave them.
> +GETTEXT_FLAGS = \
> + pg_fatal:1:c-format \
> + pg_log:2:c-format \
> + prep_status:1:c-format \
> + report_stats:2:c-forma
> s/report_stats/report_status/
ok
> In info.c, missing some entries in report_unmatched_relation() when
> reporting unmatching relations?
Yeah, that will need a bit of a rewrite, so FIXME later?
> In util.c, doesn't pg_log_v() need to handle strings used in fprintf?
Which specific lines do you have in mind?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, michael.paquier@gmail.com
Subject: Re: add more NLS to bin
In-Reply-To: <cfb0f746-ee20-226d-ff7c-a1e1b8d13445@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox