From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Use atexit() in initdb and pg_basebackup
Date: Mon, 7 Jan 2019 16:37:28 +0100
Message-ID: <d024a32c-96ac-e7c1-cc7b-024e4085f997@2ndquadrant.com> (raw)
In-Reply-To: <201901051542.macmepgkz3zr@alvherre.pgsql>
References: <201901051542.macmepgkz3zr@alvherre.pgsql>
On 05/01/2019 16:42, Alvaro Herrera wrote:
>> Yeah. Actually, we already have a solution of this in pg_basebackup,
>> with a bool success variable. I rewrote it like that. At least it's
>> better for uniformity.
>
> Ah, yeah, much better, LGTM.
>
>> I also added an atexit() conversion in isolationtester. It's mostly the
>> same thing.
>
> LGTM in a quick eyeball.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, alvherre@2ndquadrant.com
Subject: Re: Use atexit() in initdb and pg_basebackup
In-Reply-To: <d024a32c-96ac-e7c1-cc7b-024e4085f997@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox