pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jeff Davis <pgsql@j-davis.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump --with-* options
Date: Sat, 02 Aug 2025 08:34:32 -0700
Message-ID: <d02ba21d4efbb7bd048822e1d1971fae93d24104.camel@j-davis.com> (raw)
In-Reply-To: <CAHGQGwF3YcYEWuy+76t87R4jR43_gzmRr34rRPNWfCs9yGR=xA@mail.gmail.com>
References: <7cc52488-f876-4ad3-affd-6e4b0ef0cb09@eisentraut.org>
	<aEMLzPQtjRbj2R7X@nathan>
	<CA+TgmoactJEUHeXuxHLKNXHzm6-XrQFigPur-4nHTMFSiSRkiQ@mail.gmail.com>
	<aErpuM6RXSlK1FBW@nathan>
	<7bf0246542713d80f12c738c1d365d1365750c18.camel@j-davis.com>
	<5e398522803da9bf3f9fc33ca43084ec21ab0fcd.camel@j-davis.com>
	<aFLenfMRS9jFINxq@nathan>
	<031558c60e84362898922caa6a90587e7fdf2a57.camel@j-davis.com>
	<f379d0aeefe8effe13302a436bc28f549f09e924.camel@j-davis.com>
	<40cedfc22da152928a74d472708aaadb8855d8d9.camel@j-davis.com>
	<CAHGQGwF3YcYEWuy+76t87R4jR43_gzmRr34rRPNWfCs9yGR=xA@mail.gmail.com>

On Sat, 2025-08-02 at 22:58 +0900, Fujii Masao wrote:
> I'm OK with this approach. Thanks for the patch! It looks good to me.

Thank you for the review.

> -       bool            statistics_only = false;
> +       static int      statistics_only = 0;

Agreed. That can just be done for 19 though.

Regards,
	Jeff Davis







view thread (72+ messages)

Message-ID: <d02ba21d4efbb7bd048822e1d1971fae93d24104.camel@j-davis.com>
Permalink:  ../d02ba21d4efbb7bd048822e1d1971fae93d24104.camel@j-davis.com/
Also on:    postgresql.org/message-id/d02ba21d4efbb7bd048822e1d1971fae93d24104.camel@j-davis.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pgsql@j-davis.com, masao.fujii@gmail.com, nathandbossart@gmail.com, robertmhaas@gmail.com, peter@eisentraut.org
  Subject: Re: pg_dump --with-* options
  In-Reply-To: <d02ba21d4efbb7bd048822e1d1971fae93d24104.camel@j-davis.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox