From: Jonathan S. Katz <jkatz@postgresql.org>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: andres@anarazel.de
Cc: jcasanov@systemguards.com.ec
Cc: pgsql-hackers@postgresql.org
Subject: Re: START_REPLICATION SLOT causing a crash in an assert build
Date: Wed, 5 Oct 2022 13:00:53 -0400
Message-ID: <d1bd5065-ca79-d833-2d7d-0b0404589711@postgresql.org> (raw)
In-Reply-To: <20220927.145238.1330141994586078168.horikyota.ntt@gmail.com>
References: <YyNPkABHU5uWz3NS@ahch-to>
<20220916.143717.1696696757596823748.horikyota.ntt@gmail.com>
<20220927025302.xltfa7ch7vexopfj@awork3.anarazel.de>
<20220927.145238.1330141994586078168.horikyota.ntt@gmail.com>
On 9/27/22 1:52 AM, Kyotaro Horiguchi wrote:
> Thanks!
>
> At Mon, 26 Sep 2022 19:53:02 -0700, Andres Freund <andres@anarazel.de> wrote in
>> I wonder if the correct fix here wouldn't be to move the slotname out of
>> PgStat_StatReplSlotEntry?
>
> Ugh. Right. I thought its outer struct as purely the part for the
> common header. But we can freely place anything after the header
> part. I moved it to the outer struct. I didn't clear that part in
> pgstat_create_relation() because it is filled in immediately.
>
> The attached is that.
This is still listed as an open item[1] for v15. Does this fix proposed
address the issue?
Thanks,
Jonathan
[1] https://wiki.postgresql.org/wiki/PostgreSQL_15_Open_ItemsAttachments:
OpenPGP_signature (application/pgp-signature, 839B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: jkatz@postgresql.org, horikyota.ntt@gmail.com, andres@anarazel.de, jcasanov@systemguards.com.ec
Subject: Re: START_REPLICATION SLOT causing a crash in an assert build
In-Reply-To: <d1bd5065-ca79-d833-2d7d-0b0404589711@postgresql.org>
References: <YyNPkABHU5uWz3NS@ahch-to> <20220916.143717.1696696757596823748.horikyota.ntt@gmail.com> <20220927025302.xltfa7ch7vexopfj@awork3.anarazel.de> <20220927.145238.1330141994586078168.horikyota.ntt@gmail.com> <d1bd5065-ca79-d833-2d7d-0b0404589711@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox