pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jeff Davis <pgsql@j-davis.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: pgsql-hackers@postgresql.org
Subject: Re: Trouble with hashagg spill I/O pattern and costing
Date: Thu, 21 May 2020 11:19:01 -0700
Message-ID: <d1da1e990cf9d564aa435c63e1eb26748d50c10f.camel@j-davis.com> (raw)
In-Reply-To: <20200521143040.zgn7ealdasfkmfcb@development>
References: <20200519151202.u2p2gpiawoaznsv2@development>
	<20200521134122.3rpmdolam4fgc5pv@development>
	<20200521143040.zgn7ealdasfkmfcb@development>

On Thu, 2020-05-21 at 16:30 +0200, Tomas Vondra wrote:
> OK, it seems the attached trivial fix (simply changing CP_LABEL_TLIST
> to
> CP_SMALL_TLIST) addresses this for me.

Great!

There were a couple plan changes where it introduced a Subquery Scan.
I'm not sure that I understand why it's doing that, can you verify that
it is a reasonable thing to do?

Aside from that, feel free to commit it.

Regards,
	Jeff Davis







view thread (41+ messages)  latest in thread

Message-ID: <d1da1e990cf9d564aa435c63e1eb26748d50c10f.camel@j-davis.com>
Permalink:  ../d1da1e990cf9d564aa435c63e1eb26748d50c10f.camel@j-davis.com/
Also on:    postgresql.org/message-id/d1da1e990cf9d564aa435c63e1eb26748d50c10f.camel@j-davis.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pgsql@j-davis.com, tomas.vondra@2ndquadrant.com
  Subject: Re: Trouble with hashagg spill I/O pattern and costing
  In-Reply-To: <d1da1e990cf9d564aa435c63e1eb26748d50c10f.camel@j-davis.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox