pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: pgsql-hackers@postgresql.org, Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
Date: Tue, 11 Sep 2018 16:55:23 +0300
Message-ID: <d318cdee8f96de6b1caf2ce684ffe4db@postgrespro.ru> (raw)
In-Reply-To: <f167595f992d31710048f017d48626da@postgrespro.ru>
References: <20180508193621.dphlgwrd5yz67o2z@alvherre.pgsql>
	<0569c5309cf536a839e2a3a1433bd113@postgrespro.ru>
	<alpine.DEB.2.21.1807091451520.17811@lancre>
	<a6299efa310e1d106144f761259f4fd6@postgrespro.ru>
	<alpine.DEB.2.21.1807111435250.27883@lancre>
	<976a25a46420c93866ada4051976b1be@postgrespro.ru>
	<alpine.DEB.2.21.1807112124210.27883@lancre>
	<f153ffd55f481d714ee44afc99ecc67e@postgrespro.ru>
	<alpine.DEB.2.21.1807121801250.27883@lancre>
	<25d7b1f518c218a8c335bdfc6c858ea1@postgrespro.ru>
	<alpine.DEB.2.21.1808151046090.30050@lancre>
	<92869f967d690848c456ac44b371482c@postgrespro.ru>
	<alpine.DEB.2.21.1808170917510.20841@lancre>
	<48b325aa26bb51381a21b27b1553878d@postgrespro.ru>
	<alpine.DEB.2.21.1808171302510.20841@lancre>
	<edb5add98f8dbe433c428958c5390000@postgrespro.ru>
	<a1bd32671a6777b78dd67b95eb68ff82@postgrespro.ru>
	<alpine.DEB.2.21.1809081450100.10506@lancre>
	<f167595f992d31710048f017d48626da@postgrespro.ru>

On 11-09-2018 16:47, Marina Polyakova wrote:
> On 08-09-2018 16:03, Fabien COELHO wrote:
>> Hello Marina,
>> I'd insist in a comment that "cnt" does not include "skipped" 
>> transactions
>> (anymore).
> 
> If you mean CState.cnt I'm not sure if this is practically useful
> because the code uses only the sum of all client transactions
> including skipped and failed... Maybe we can rename this field to
> nxacts or total_cnt?

Sorry, I misread your proposal for the first time. Ok!

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company




view thread (137+ messages)  latest in thread

Message-ID: <d318cdee8f96de6b1caf2ce684ffe4db@postgrespro.ru>
Permalink:  ../d318cdee8f96de6b1caf2ce684ffe4db@postgrespro.ru/
Also on:    postgresql.org/message-id/d318cdee8f96de6b1caf2ce684ffe4db@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: m.polyakova@postgrespro.ru, coelho@cri.ensmp.fr, alvherre@2ndquadrant.com, i.kurbangaliev@postgrespro.ru, teodor@sigaev.ru
  Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
  In-Reply-To: <d318cdee8f96de6b1caf2ce684ffe4db@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox