From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com
Cc: rjuju123@gmail.com
Cc: daniel@manitou-mail.org
Cc: AndrewBille@gmail.com
Cc: michael@paquier.xyz
Subject: Re: ICU for global collation
Date: Sat, 17 Sep 2022 09:25:00 +0300
Message-ID: <d75bbfc82228895590e56b53e1d640d8@postgrespro.ru> (raw)
In-Reply-To: <f1b3baa6-2bad-8be6-1458-3769f5c5989c@enterprisedb.com>
References: <6dd6db0984d86a51b7255ba79f111971@postgrespro.ru>
<20220915.155210.529619933474389138.horikyota.ntt@gmail.com>
<2322791a368e9ad066edd648790b5e91@postgrespro.ru>
<20220916.135519.1552320805811493586.horikyota.ntt@gmail.com>
<1989d430b926be3c08735f97fffc6294@postgrespro.ru>
<f1b3baa6-2bad-8be6-1458-3769f5c5989c@enterprisedb.com>
On 2022-09-16 10:57, Peter Eisentraut wrote:
> On 16.09.22 09:31, Marina Polyakova wrote:
>> IMO it is hardly understantable from the program output either - it
>> looks like I manually chose the encoding UTF8. Maybe first inform
>> about selected encoding?..
>
> Yes, I included something like that in the patch just committed.
>
>> diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
>> index
>> 6aeec8d426c52414b827686781c245291f27ed1f..348bbbeba0f5bc7ff601912bf883510d580b814c
>> 100644
>> --- a/src/bin/initdb/initdb.c
>> +++ b/src/bin/initdb/initdb.c
>> @@ -2310,7 +2310,11 @@ setup_locale_encoding(void)
>> }
>>
>> if (!encoding && locale_provider == COLLPROVIDER_ICU)
>> + {
>> encodingid = PG_UTF8;
>> + printf(_("The default database encoding has been set to
>> \"%s\" for a better experience with the ICU provider.\n"),
>> + pg_encoding_to_char(encodingid));
>> + }
>> else if (!encoding)
>> {
>> int ctype_enc;
Thank you!
--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: m.polyakova@postgrespro.ru, peter.eisentraut@enterprisedb.com, horikyota.ntt@gmail.com, pryzby@telsasoft.com, rjuju123@gmail.com, daniel@manitou-mail.org, AndrewBille@gmail.com, michael@paquier.xyz
Subject: Re: ICU for global collation
In-Reply-To: <d75bbfc82228895590e56b53e1d640d8@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox