pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Erik Rijkers <er@xs4all.nl>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Date: Sat, 3 Mar 2018 15:52:40 +0100
Message-ID: <d807dc44-55f9-5c23-97e5-a5881f4135e2@2ndquadrant.com> (raw)
In-Reply-To: <cb2530b102afad854e051cca44577c6a@xs4all.nl>
References: <688b0b7f-2f6c-d827-c27b-216a8e3ea700@2ndquadrant.com>
	<bbe1333f-17ba-1156-0713-7cc0bfe2d842@2ndquadrant.com>
	<bc83b847-2fc7-6561-4ef1-a3c9d154cc31@2ndquadrant.com>
	<47223121-222d-8e04-4928-a28ecdc5327d@2ndquadrant.com>
	<CAD21AoBa2mhbhZW6hnDRKs1ggycJOBE69eHk3KgCJ5Cwj9-ZkA@mail.gmail.com>
	<b9b306a3-c0a2-7eb9-92eb-a3ca111bd1bc@2ndquadrant.com>
	<4762f6bd-b147-cd06-f286-22f54790b77d@2ndquadrant.com>
	<cb2530b102afad854e051cca44577c6a@xs4all.nl>



On 03/03/2018 06:19 AM, Erik Rijkers wrote:
> On 2018-03-03 01:55, Tomas Vondra wrote:
>> Hi there,
>>
>> attached is an updated patch fixing all the reported issues (a bit more
>> about those below).
> 
> Hi,
> 
> 0007-Track-statistics-for-streaming-spilling.patch  won't apply.  All
> the other patches apply ok.
> 
> patch complaints with:
> 
> patching file doc/src/sgml/monitoring.sgml
> patching file src/backend/catalog/system_views.sql
> Hunk #1 succeeded at 734 (offset 2 lines).
> patching file src/backend/replication/logical/reorderbuffer.c
> patching file src/backend/replication/walsender.c
> patching file src/include/catalog/pg_proc.h
> Hunk #1 FAILED at 2903.
> 1 out of 1 hunk FAILED -- saving rejects to file
> src/include/catalog/pg_proc.h.rej
> patching file src/include/replication/reorderbuffer.h
> patching file src/include/replication/walsender_private.h
> patching file src/test/regress/expected/rules.out
> Hunk #1 succeeded at 1861 (offset 2 lines).
> 
> Attached the produced reject file.
> 

Yeah, that's due to fd1a421fe66 which changed columns in pg_proc.h.
Attached is a rebased patch, fixing this.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

  0001-Introduce-logical_work_mem-to-limit-ReorderBuffer.patch.gz (application/gzip, 9.9K) download

  0002-Immediatel-WAL-log-assignments.patch.gz (application/gzip, 6.7K) download

  0003-Issue-individual-invalidations-with-wal_level-logica.patch.gz (application/gzip, 4.8K) download

  0004-Extend-the-output-plugin-API-with-stream-methods.patch.gz (application/gzip, 5.3K) download

  0005-Implement-streaming-mode-in-ReorderBuffer.patch.gz (application/gzip, 10.8K) download

  0006-Add-support-for-streaming-to-built-in-replication.patch.gz (application/gzip, 19.6K) download

  0007-Track-statistics-for-streaming-spilling.patch.gz (application/gzip, 4.3K) download

  0008-BUGFIX-make-sure-subxact-is-marked-as-is_known_as_su.patch.gz (application/gzip, 570B) download

  0009-BUGFIX-set-final_lsn-for-subxacts-before-cleanup.patch.gz (application/gzip, 626B) download

view thread (536+ messages)  latest in thread

Message-ID: <d807dc44-55f9-5c23-97e5-a5881f4135e2@2ndquadrant.com>
Permalink:  ../d807dc44-55f9-5c23-97e5-a5881f4135e2@2ndquadrant.com/
Also on:    postgresql.org/message-id/d807dc44-55f9-5c23-97e5-a5881f4135e2@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, er@xs4all.nl, sawada.mshk@gmail.com
  Subject: Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
  In-Reply-To: <d807dc44-55f9-5c23-97e5-a5881f4135e2@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox