From: ilmari@ilmari.org
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: pgsql-hackers\@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: REINDEX CONCURRENTLY 2.0
Date: Thu, 11 Apr 2019 11:21:29 +0100
Message-ID: <d8jftqo3kra.fsf@dalvik.ping.uio.no> (raw)
In-Reply-To: <13fb3e06-3b66-e878-26d8-0d77e7d50160@2ndquadrant.com>
References: <CAB7nPqSTFkuc7dZxCDX4HOTU63YXHRroNv2aoUzyD-Zz_8Z_Zg@mail.gmail.com>
<c7c30d5c-666f-ca8b-29ad-12b9a28f11de@2ndquadrant.com>
<154954968565.11785.6973123402105637191.pgcf@coridan.postgresql.org>
<1730471552486423@myt1-cd60b8ae9bb9.qloud-c.yandex.net>
<3b33640c-5493-4eea-fd5f-71d37626fe2f@2ndquadrant.com>
<1907751553367887@myt6-23299ba78d64.qloud-c.yandex.net>
<64744529-d34e-9aae-e7e3-e2263c24fb3b@2ndquadrant.com>
<7380711553760479@iva5-0acfc31d2b43.qloud-c.yandex.net>
<13fb3e06-3b66-e878-26d8-0d77e7d50160@2ndquadrant.com>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2019-03-28 09:07, Sergei Kornilov wrote:
>> Unfortunately patch does not apply due recent commits. Any chance
>> this can be fixed (and even committed in pg12)?
>
> Committed :)
I noticed that the docs for how to recover from a failed CREATE INDEX
CONCURRENTLY say that «REINDEX does not support concurrent builds»,
which is no longer true. I was going to just remove the caveat, but
then I discovered that REINDEX CONCURRENTLY doesn't work on INVALID
indexes (why?).
Attached is a patch that instead adjust the claim to say that REINDEX
dos not support rebulilding invalid indexess concurrently.
- ilmari
--
"A disappointingly low fraction of the human race is,
at any given time, on fire." - Stig Sandbeck Mathisen
Attachments:
[text/x-diff] 0001-Correct-claim-about-REINDEX-CONCURRENTLY-in-CREATE-I.patch (1.1K, ../d8jftqo3kra.fsf@dalvik.ping.uio.no/2-0001-Correct-claim-about-REINDEX-CONCURRENTLY-in-CREATE-I.patch)
download | inline diff:
From e2de72b348f8a96e24128fc4188bd542eb676610 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dagfinn=20Ilmari=20Manns=C3=A5ker?= <ilmari@ilmari.org>
Date: Thu, 11 Apr 2019 10:58:47 +0100
Subject: [PATCH] Correct claim about REINDEX CONCURRENTLY in CREATE INDEX
CONCURRENTLY docs
REINDEX CONCURRENTLY exists, but cannot reindex invalid indexes.
---
doc/src/sgml/ref/create_index.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgmlindex d9d95b20e3..c458f54ef1 100644--- a/doc/src/sgml/ref/create_index.sgml+++ b/doc/src/sgml/ref/create_index.sgml@@ -557,8 +557,8 @@
method in such cases is to drop the index and try again to perform
<command>CREATE INDEX CONCURRENTLY</command>. (Another possibility is to rebuild
the index with <command>REINDEX</command>. However, since <command>REINDEX</command>
- does not support concurrent builds, this option is unlikely to seem- attractive.)+ does not support reindexing invalid indexes concurrently, this option is+ unlikely to seem attractive.)
</para>
<para>
--
2.20.1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ilmari@ilmari.org, peter.eisentraut@2ndquadrant.com, sk@zsrv.org, pgsql-hackers@lists.postgresql.org
Subject: Re: REINDEX CONCURRENTLY 2.0
In-Reply-To: <d8jftqo3kra.fsf@dalvik.ping.uio.no>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox