pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: non-bulk inserts and tuple routing
Date: Mon, 5 Mar 2018 13:21:51 +0900
Message-ID: <d9f2ef8c-a83e-7823-d73a-ba23ea2e7ffb@lab.ntt.co.jp> (raw)
In-Reply-To: <20180303044855.f25y6xmil5fnp2g7@alap3.anarazel.de>
References: <c0c02a3f-5eba-77c5-5476-95e1f003623e@lab.ntt.co.jp>
	<5A8652E3.9000009@lab.ntt.co.jp>
	<caf71439-fd65-864e-c441-4053430f812e@lab.ntt.co.jp>
	<5A86A093.4010406@lab.ntt.co.jp>
	<b34e69b2-5d67-29f1-7a35-6b6299243ec0@lab.ntt.co.jp>
	<5A86B77E.1010306@lab.ntt.co.jp>
	<c3b19f9d-dfc0-12b0-7bd3-cb38aa86d4f5@lab.ntt.co.jp>
	<5A8BFB31.6030707@lab.ntt.co.jp>
	<a8ae6e4e-f07b-76ab-4140-0d1be48747b6@lab.ntt.co.jp>
	<CA+TgmoZYBc7HO6CfCTaksD40UyeM8+6_ShXs6XrYu5H0UC4SLQ@mail.gmail.com>
	<20180303044855.f25y6xmil5fnp2g7@alap3.anarazel.de>

On 2018/03/03 13:48, Andres Freund wrote:
> On 2018-02-22 11:10:57 -0500, Robert Haas wrote:
>> On Tue, Feb 20, 2018 at 8:06 PM, Amit Langote
>> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>>>> Attached is an updated version for that.
>>>
>>> Thanks for updating the patch.
>>
>> Committed with a few changes.  The big one was that I got rid of the
>> local variable is_update in ExecSetupPartitionTupleRouting.  That
>> saved a level of indentation on a substantial chunk of code, and it
>> turns out that test was redundant anyway.
> 
> Btw, are there cases where this could change explain output?  If there's
> subplan references or such in any of returning / wcte expressions,
> they'd not get added at explain time.  It's probably fine because add
> the expressions also "staticly" in ExecInitModifyTable()?

Yes, I think.

Afaics, explain.c only looks at the information that is "statically" added
to ModifyTableState by ExecInitModifyTable.  It considers information
added by the tuple routing code only when printing information about
invoked triggers, that too, only in the case of EXPLAIN ANALYZE.

Thanks,
Amit





view thread (43+ messages)

Message-ID: <d9f2ef8c-a83e-7823-d73a-ba23ea2e7ffb@lab.ntt.co.jp>
Permalink:  ../d9f2ef8c-a83e-7823-d73a-ba23ea2e7ffb@lab.ntt.co.jp/
Also on:    postgresql.org/message-id/d9f2ef8c-a83e-7823-d73a-ba23ea2e7ffb@lab.ntt.co.jp

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: Langote_Amit_f8@lab.ntt.co.jp, andres@anarazel.de, robertmhaas@gmail.com, fujita.etsuro@lab.ntt.co.jp, pgsql-hackers@lists.postgresql.org
  Subject: Re: non-bulk inserts and tuple routing
  In-Reply-To: <d9f2ef8c-a83e-7823-d73a-ba23ea2e7ffb@lab.ntt.co.jp>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox