pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Andrew Dunstan <andrew@dunslane.net>
To: David Steele <david@pgmasters.net>
To: Nikita Glukhov <n.gluhov@postgrespro.ru>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Oleg Bartunov <obartunov@gmail.com>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Zhihong Yu <zyu@yugabyte.com>
Subject: Re: SQL/JSON: JSON_TABLE
Date: Fri, 26 Mar 2021 16:28:58 -0400
Message-ID: <dacf209e-b098-41bf-2d1c-4cf6e64ad511@dunslane.net> (raw )
In-Reply-To: <775a7d16-481c-978f-a6cf-29604a38102b@pgmasters.net >
References: <CAFj8pRAyMkNDJ=aGQFw2eai=FA6tr-asv2-dvUhveq=Ek5Vk8w@mail.gmail.com >
<f3cef7f6-ae6a-a02b-83cb-542f170dff45@postgrespro.ru >
<CAFj8pRB1RtXAezZVWAmgrX-zeHVADLnYNidqay5p-E+66pwgjw@mail.gmail.com >
<0350fdf8-c44d-46ab-6cc3-d39e77130cb1@postgrespro.ru >
<CAFj8pRCCyACYVA4DHCNVTQteRrWmE_BiPGKdWJfiN3i0jj0TjQ@mail.gmail.com >
<df16e6d8-4de6-f228-5109-60aefed5d180@postgrespro.ru >
<CAFj8pRBaSA06w9WzG52Qu7r10MT2Qxd9Pzg0bbiZCCS_QKhgkg@mail.gmail.com >
<CAFj8pRC8MU2VxY=zYMnG1haM=pfvrRMYJfpt+-C2ACG1L4QdOQ@mail.gmail.com >
<bfcb411e-8dab-1fae-ed22-2aebaf584a5f@postgrespro.ru >
<20200705171558.GP4107@telsasoft.com >
<20200803075558.GQ3317@paquier.xyz >
<7e2cb85d-24cf-4abb-30a5-1a33715959bd@postgrespro.ru >
<CALNJ-vTXxYOy9baMhFRQH9S5KUkuy8UfO4EpjQv77H7ymcN6nA@mail.gmail.com >
<cf448269-f62f-b0ac-14d0-1972ac3a8c3a@postgrespro.ru >
<775a7d16-481c-978f-a6cf-29604a38102b@pgmasters.net >
On 3/25/21 8:10 AM, David Steele wrote:
> On 1/20/21 8:42 PM, Nikita Glukhov wrote:
>> Thank you for review.
>>
>> Attached 45th version of the patches. "SQL/JSON functions" patch
>> corresponds to
>> v52 patch set posted in the separate thread.
>
> Another rebase needed (http://cfbot.cputube.org/patch_32_2902.log ),
> marked Waiting on Author.
>
> I can see that Álvaro suggested that the patch be split up so it can
> be reviewed and committed in pieces. It looks like you've done that to
> some extent, but I wonder if more can be done. In particular, it looks
> like that first patch could be broken up -- at lot.
>
>
I've rebased this. Note that the large first patch is just the
accumulated patches from the 'SQL/JSON functions' thread, and should be
reviewed there. Only patches 2 thru 4 should be reviewed here. In fact
there are no changes at all in those patches from the previous set other
than a little patch fuzz. The only substantial changes are in patch 1,
which had bitrotted. However, I'm posting a new series to keep the
numbering in sync.
If the cfbot is happy I will set back to 'Needs review'
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Attachments:
0001-SQL-JSON-functions-v46.patch.gz (application/gzip, 72.9K) download
0002-JSON_TABLE-v46.patch.gz (application/gzip, 18.7K) download
0003-JSON_TABLE-PLAN-DEFAULT-clause-v46.patch.gz (application/gzip, 5.9K) download
0004-JSON_TABLE-PLAN-clause-v46.patch.gz (application/gzip, 5.8K) download
view thread (98+ messages) latest in thread
Message-ID: <dacf209e-b098-41bf-2d1c-4cf6e64ad511@dunslane.net>
Permalink: ../dacf209e-b098-41bf-2d1c-4cf6e64ad511@dunslane.net/
Also on: postgresql.org/message-id/dacf209e-b098-41bf-2d1c-4cf6e64ad511@dunslane.net
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew@dunslane.net, david@pgmasters.net, n.gluhov@postgrespro.ru, michael@paquier.xyz, pryzby@telsasoft.com, pavel.stehule@gmail.com, robertmhaas@gmail.com, 9erthalion6@gmail.com, obartunov@gmail.com, andrew.dunstan@2ndquadrant.com, zyu@yugabyte.com
Subject: Re: SQL/JSON: JSON_TABLE
In-Reply-To: <dacf209e-b098-41bf-2d1c-4cf6e64ad511@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox